Skip to content

[PRMP-808] Review - POST request for uploading review items #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steph-torres-nhs merged 42 commits into from
Dec 19, 2025
Merged

[PRMP-808] Review - POST request for uploading review items #937

steph-torres-nhs merged 42 commits into from
Dec 19, 2025

Conversation

@steph-torres-nhs
Copy link
Contributor

@steph-torres-nhs steph-torres-nhs commented Dec 9, 2025 •
edited
Loading

Overview

Jira ticket: PRMP-808

Description

Create POST DocumentReview/ logic

Context

Users need to be able to upload documents ready for review using CloudFront and a pre-signed URL.

Checklist

Tasks for all changes:

  • 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits. (WIP)
  • 3. I have added and/or updated relevant tests.
  • [ ] 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:

@steph-torres-nhs
[PRMP-808] start implementation of handler
cd692ca
@steph-torres-nhs
[PRMP-808] throw error unsupported snomed code
f337af6
@steph-torres-nhs
[PRMP-808] introduce service
ac217f0
@steph-torres-nhs
[PRMP-808] introduce ods util for extracting ods code from request co…
a5e3153 
…ntext
@steph-torres-nhs
[PRMP-808] service extracts ods code from request context used as author
fc3af04
@steph-torres-nhs
[PRMP-808] handler failure to extract ods code from request context
df33e89
@steph-torres-nhs
[PRMP-808] forgot to add test file for service
bdb73c5
@steph-torres-nhs
[PRMP-808] refactor err_codes, model validation handles nhs number va…
8795143 
…lidation
@steph-torres-nhs
[PRMP-808] SearchDocumentReview returns camel case response
8c04b1b
@steph-torres-nhs
[PRMP-808] get_document_review returns camel case object
9f30622
@steph-torres-nhs
[PRMP-808] model does not accept extra data, explicitly forbidden
aecc351
@steph-torres-nhs
[PRMP-808] document upload review service calls dynamo service to cre…
f2c35db 
…ate new items in review table
@steph-torres-nhs
[PRMP-808] document upload review service raise error invalid object …
a01a68f 
…to write to dynamodb
@steph-torres-nhs
[PRMP-808] service creates presign url
53fb513
@steph-torres-nhs
[PRMP-808] add error handling for presign url creation failure
8f8084a
@steph-torres-nhs
Merge branch 'main' into PRMP-808
3ee8378
@steph-torres-nhs
[PRMP-808] refactor happy path test
629f30e
@steph-torres-nhs
[PRMP-808] format
50155e9
@steph-torres-nhs
[PRMP-808] format
9976269
@steph-torres-nhs
[PRMP-808] add test for multi file upload
a036b86
@steph-torres-nhs
[PRMP-808] take in updated cloudfront script
906e4e2
@steph-torres-nhs
[PRMP-808] add lambda to workflow
1e034a3
@steph-torres-nhs
[PRMP-808] update workflow
e8b6a28
@steph-torres-nhs
[PRMP-808] use json event in handler
36e7e4d
@steph-torres-nhs
[PRMP-808] add version to return object
0c34c21
@steph-torres-nhs
[PRMP-808] add exclude none to model dump
cb1d252
@steph-torres-nhs
[PRMP-808] merge in main
a7a8117
@steph-torres-nhs steph-torres-nhs marked this pull request as ready for review December 9, 2025 10:48
@steph-torres-nhs steph-torres-nhs requested a review from a team as a code owner December 9, 2025 10:48
NogaNHS
NogaNHS reviewed Dec 18, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Code security issues found

View full details here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 18, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
98.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@steph-torres-nhs steph-torres-nhs merged commit a993ea8 into main Dec 19, 2025
27 of 28 checks passed
@steph-torres-nhs steph-torres-nhs deleted the PRMP-808 branch December 19, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NogaNHS NogaNHS NogaNHS approved these changes

@kamenbachvarov-nhs kamenbachvarov-nhs kamenbachvarov-nhs approved these changes

@PedroSoaresNHS PedroSoaresNHS PedroSoaresNHS left review comments

@SteveMahoneyNHS SteveMahoneyNHS Awaiting requested review from SteveMahoneyNHS SteveMahoneyNHS is a code owner automatically assigned from NHSDigital/access-store

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@steph-torres-nhs @NogaNHS @PedroSoaresNHS @kamenbachvarov-nhs @bethany-kish-nhs