Skip to content

Conversation

@lillie-dae
Copy link
Contributor

@lillie-dae lillie-dae commented Dec 1, 2025

Overview

Jira ticket: PRMP-827

Description

Context

This ticket covers accepting or rejecting single documents and calling the API endpoints for adding them into the NDR. This also covers scenarios where a document can be discarded if the data controlling practice doesn't want it after confirming demographics.

Scope

  • Feature flagged uploadDocumentIteration3Enabled
  • Stub structures for end to end review journey, including reassign
  • Confirm patient demographics
  • Review existing files
  • Choose files to add
  • Download excluded documents
  • Confirmation for not adding any documents
  • Reassign
  • Uploading and review complete
  • Review list to account for document configuration flow

Out of Scope

  • API calls
  • Adding more files
  • Replace journey - to come later
  • Guidance to come where the user goes out of review, removes the file and then completes the review
  • Cannot discard scenarios - EHRs & attachment being a snapshot means we auto accept into the NDR
  • Go straight to progress upload screen (PRMP-837)

Checklist

Tasks for all changes:

  • 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits. (WIP)
  • 3. I have added and/or updated relevant tests.
  • 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:

Additional tasks for UI changes (delete if not applicable):

  • 1. I have run the UI Smoke Tests against the deployed sandbox and witnessed it passing:
  • 2. I have added evidence (to this PR) e.g. screenshots/gifs of all visual changes.

Here's some videos. some minor content changes since taking the videos. essentially same though.

review-different.assessment.pages.webm
review-Success-Add-More.webm
review-Success-Duplicate.webm

@lillie-dae lillie-dae force-pushed the PRMP-828 branch 2 times, most recently from 8c1dd20 to 3e426a0 Compare December 2, 2025 13:56
@lillie-dae lillie-dae marked this pull request as ready for review December 2, 2025 14:12
@lillie-dae lillie-dae requested review from a team as code owners December 2, 2025 14:12
adamwhitingnhs
adamwhitingnhs previously approved these changes Dec 17, 2025
@lillie-dae lillie-dae force-pushed the PRMP-828 branch 2 times, most recently from 7966b82 to a8d40ec Compare December 23, 2025 10:00
@sonarqubecloud
Copy link

Copy link
Contributor

@steph-torres-nhs steph-torres-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has two previous approvals

@lillie-dae lillie-dae merged commit b53537b into main Dec 23, 2025
20 checks passed
@lillie-dae lillie-dae deleted the PRMP-828 branch December 23, 2025 11:29
megan-bower4 pushed a commit that referenced this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants