Skip to content

[PRMP-1208] content change error message#1062

Open
SWhyteAnswer wants to merge 3 commits intomainfrom
PRMP-1208
Open

[PRMP-1208] content change error message#1062
SWhyteAnswer wants to merge 3 commits intomainfrom
PRMP-1208

Conversation

@SWhyteAnswer
Copy link
Contributor

@SWhyteAnswer SWhyteAnswer commented Feb 9, 2026 •
edited
Loading

Overview

Jira ticket: TBC

Description

Context

Checklist

Tasks for all changes:

  • 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits. (WIP)
  • 3. I have added and/or updated relevant tests.
  • 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:

Additional tasks for UI changes (delete if not applicable):

  • 1. I have run the UI Smoke Tests against the deployed sandbox and witnessed it passing:
  • 2. I have added evidence (to this PR) e.g. screenshots/gifs of all visual changes.

@SWhyteAnswer
Copy link
Contributor Author

SWhyteAnswer commented Feb 9, 2026

image

@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Code security issues found

View full details here.

2 similar comments
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Code security issues found

View full details here.

@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Code security issues found

View full details here.

@SWhyteAnswer SWhyteAnswer marked this pull request as ready for review February 10, 2026 15:12
@SWhyteAnswer SWhyteAnswer requested review from a team as code owners February 10, 2026 15:12
@SWhyteAnswer SWhyteAnswer reopened this Feb 10, 2026
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Code security issues found

View full details here.

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Code security issues found

View full details here.

NogaNHS
NogaNHS reviewed Feb 11, 2026
View reviewed changes
...components/blocks/_admin/reviewDetailsPatientSearchStage/ReviewDetailsPatientSearchStage.tsx

export const incorrectFormatMessage = "Enter patient's 10 digit NHS number";
export const incorrectFormatMessage =
"Enter a valid patient NHS number. If you keep getting this message, select 'I don't know the NHS number'.";
Copy link
Contributor

@NogaNHS NogaNHS Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test?

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Code security issues found

View full details here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 12, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NogaNHS NogaNHS NogaNHS left review comments

@steph-torres-nhs steph-torres-nhs steph-torres-nhs left review comments

@AndyFlintAnswerDigital AndyFlintAnswerDigital Awaiting requested review from AndyFlintAnswerDigital AndyFlintAnswerDigital is a code owner automatically assigned from NHSDigital/access-store

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SWhyteAnswer @NogaNHS @steph-torres-nhs