Skip to content

Conversation

@edhall-nhs
Copy link
Contributor

@edhall-nhs edhall-nhs commented Feb 12, 2026

Summary

  • 🤖 Operational or Infrastructure Change

Adds imms-metrics-dashboard-dev to our IAC.

Some notes:

  • I've focussed on high level Metrics across the dev account. For Lambda, this includes PR environments due to the nature of the metrics but for other services (e.g. DynamoDB) I've only included internal-dev and internal-qa.
  • I couldn't find an easy way to switch between sub-environments, hence the above approach. Open to suggestions.
  • Since the environments are somewhat fixed in this case, I felt there would be limited benefit of keeping the dashboard in terraform and parameterising. Therefore I've captured the dashboard config in a JSON file and referenced it in Terraform. The dashboard can then be easily edited in the AWS console and the changes copy/pasted into the JSON file.
  • I've used the is_temp variable we have in terraform to only deploy on merge. This is to prevent the PR teardown pipeline deleting the dashboard. If someone wants to verify their changes will deploy before merge in the future, they can temporarily remove the condition and deploy locally.
  • I have made a temporary dashboard called imms-metrics-dashboard-dev-pr for reviewers of this PR to look at. I'll delete it once this PR has merged and successfully deployed the new dashboard.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-1044

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant