-
Notifications
You must be signed in to change notification settings - Fork 1
Chore: [AEA-5803] - move secret creation into psu repo #2406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-5803 |
connoravo-nhs
approved these changes
Nov 13, 2025
|
tstephen-nhs
added a commit
to NHSDigital/electronic-prescription-service-account-resources
that referenced
this pull request
Dec 18, 2025
## Summary - 🤖 Operational or Infrastructure Change ### Details * Remove secrets that have been moved to PSU repo. Do not merge until the release _after_ NHSDigital/eps-prescription-status-update-api#2406 rolled out. --------- Signed-off-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com> Co-authored-by: Connor Avery <214469360+connoravo-nhs@users.noreply.github.com> Co-authored-by: Connor Avery <connor.avery2@nhs.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Summary
Details
Rename secrets and bring them back from account resources
One benefit of the secrets being in the same repo as the consuming code is that we don't need to feed the secret names into the SAM templates but can instead use outputs of the secret template.