Skip to content

Update: [AEA-5919] - Split reformulation and rag prompts, versioning and refinement #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kieran-wilkinson-4 merged 27 commits into from
Dec 2, 2025
Merged

Update: [AEA-5919] - Split reformulation and rag prompts, versioning and refinement #169

kieran-wilkinson-4 merged 27 commits into from
Dec 2, 2025

Conversation

@kieran-wilkinson-4
Copy link
Contributor

@kieran-wilkinson-4 kieran-wilkinson-4 commented Nov 21, 2025 •
edited
Loading

Summary

  • Routine Change

Details

  • Update CDK for Prompt Management
    • Reformulate user prompt for improved user queries (default value for now)
    • Set system and user prompt for RAG
    • Set prompt inference for consistent results
    • Move prompts to .txt files for easier readability
  • Update slack bot to read prompts and inference from Bedrock
  • Add tests for prompt retrieval

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket:

AEA-5919

bencegadanyi1-nhs
bencegadanyi1-nhs reviewed Nov 27, 2025
View reviewed changes
Copy link
Contributor

@bencegadanyi1-nhs bencegadanyi1-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just a minor clean up near bedrock.py and prompt_loader.py to look at and then ready for re-review!

@kieran-wilkinson-4 kieran-wilkinson-4 changed the title Update: [AEA-5919] - Sandbox environment for prompt engineering Update: [AEA-5919] - Split reformulation and rag prompts, versioning and refinement Nov 27, 2025
anthony-nhs
anthony-nhs reviewed Nov 28, 2025
View reviewed changes
anthony-nhs
anthony-nhs reviewed Nov 28, 2025
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kieran-wilkinson-4 kieran-wilkinson-4 enabled auto-merge (squash) December 2, 2025 15:07
@kieran-wilkinson-4 kieran-wilkinson-4 merged commit 112ebf7 into main Dec 2, 2025
12 checks passed
@kieran-wilkinson-4 kieran-wilkinson-4 deleted the AEA-5919-Kieran branch December 2, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bencegadanyi1-nhs bencegadanyi1-nhs bencegadanyi1-nhs left review comments

@anthony-nhs anthony-nhs anthony-nhs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kieran-wilkinson-4 @anthony-nhs @bencegadanyi1-nhs