Fix: [AEA-0000] - move create release notes to github action #3668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bencegadanyi1-nhs
left a comment
bencegadanyi1-nhs
left a comment
There was a problem hiding this comment.
do we still need the azure/template files or can we delete them?
Comment on lines
-6
to
-27
| # call create release notes | ||
| - bash: | | ||
| export NOTIFY_GITHUB_REPOSITORY=$(NOTIFY_GITHUB_REPOSITORY) | ||
| export BRANCH_NAME=$(Build.SourceBranchName) | ||
| if [ "${BRANCH_NAME}" = "merge" ]; then | ||
| export BRANCH_NAME=$(echo "$(System.PullRequest.SourceBranch)" | awk -F/ '{print $NF}') | ||
| fi | ||
| if [[ -z ${NOTIFY_GITHUB_REPOSITORY} ]]; then | ||
| export NOTIFY_GITHUB_REPOSITORY=$(Build.Repository.Name) | ||
| fi | ||
| cat <<EOF > payload.json | ||
| { | ||
| "ref": "${BRANCH_NAME}" | ||
| } | ||
| EOF | ||
| echo "##[debug] Hitting https://api.github.com/repos/${NOTIFY_GITHUB_REPOSITORY}/actions/workflows/create_int_release_notes.yml/dispatches" | ||
| cat payload.json | ||
| curl --fail -q -X POST "https://api.github.com/repos/${NOTIFY_GITHUB_REPOSITORY}/actions/workflows/create_int_release_notes.yml/dispatches" -d "@./payload.json" --user $(GITHUB_USER):$(GITHUB_ACCESS_TOKEN) | ||
| echo "##[debug] Hitting https://api.github.com/repos/${NOTIFY_GITHUB_REPOSITORY}/actions/workflows/create_prod_release_notes.yml/dispatches" | ||
| curl --fail -q -X POST "https://api.github.com/repos/${NOTIFY_GITHUB_REPOSITORY}/actions/workflows/create_prod_release_notes.yml/dispatches" -d "@./payload.json" --user $(GITHUB_USER):$(GITHUB_ACCESS_TOKEN) | ||
| displayName: Create release notes post dev |
Contributor
There was a problem hiding this comment.
question: can we not just delete these azure template files completely at this stage if we are already deleting the functionalities?
anthony-nhs
had a problem deploying
to
internal-dev
GitHub Actions
Failure
anthony-nhs
had a problem deploying
to
internal-dev
GitHub Actions
Failure
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details