refactor: restructure parse spectra response and improve logging#107
Merged
NishaSharma14 merged 1 commit intodevelopmentfrom Feb 25, 2026
Merged
refactor: restructure parse spectra response and improve logging#107NishaSharma14 merged 1 commit intodevelopmentfrom
NishaSharma14 merged 1 commit intodevelopmentfrom
Conversation
Wrap `data` and `version` under `nmriumState`, and rename `errors` to `logs` to capture all log levels (info, warn, error, debug, ...etc) instead of errors only.
393643e to
1ca10bd
Compare
NishaSharma14
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We did further modifications to the response object structure for the parse-spectra API.
Currently, the response includes an errors field which, as the name suggests, only captures error-level messages. However, the goal is to extend this to capture all log levels, including info, warn, error, debug, etc., so that API users have full visibility into what happened during the parsing process, not just when something went wrong.
To achieve this, we need to:
errorstologsdataandversioninside annmriumStateobjectUpdated Response Structure:
{ "nmriumState": { "data": {}, "version": <version number> }, "images": {}, "logs": [] }