[CS-1367] Add hotmail.ca to personal email domains#41
Merged
draganfabijan merged 3 commits intomainfrom Jan 30, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds hotmail.ca to the list of recognized personal email domains in response to a request from Fasken. It includes appropriate version bumping and changelog updates for both the new change and a previously missing v2.0.7 entry.
Changes:
- Added
hotmail.cato the free email provider domains list - Added changelog entries for versions 2.0.8 and 2.0.7
- Bumped gem version from 2.0.7 to 2.0.8
- Added PR template for future contributions
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/rails_values/free_email_provider_domains.txt | Added hotmail.ca to the alphabetically sorted list of personal email domains |
| spec/rails_values/email_address_spec.rb | Added test case verifying hotmail.ca is recognized as a free email domain |
| rails_values.gemspec | Bumped version from 2.0.7 to 2.0.8 |
| CHANGELOG.md | Added entries for v2.0.8 (current changes) and v2.0.7 (previously missing) |
| .github/pull_request_template.md | Added new PR template with checklist for changelog and version updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
draganfabijan
requested review from
grantspeelman,
richardchou-nexl and
wethu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hotmail.cato the list of recognized personal email domains (requested by Fasken)Checklist
rails_values.gemspecTest plan
hotmail.cabeing recognized as a personal email domain