Skip to content

Fix JobSerializer serialize? to handle all LinkedinUrlValue types #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grantspeelman merged 1 commit into from
Jan 20, 2026
Merged

Fix JobSerializer serialize? to handle all LinkedinUrlValue types #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.2.4] - 2026-01-20

### Changed

- Updated `JobSerializer#serialize?` to check for `LinkedinUrlValue::Base` instead of `klass`. This fixes `ActiveJob::SerializationError: Unsupported argument type: LinkedinUrlValue::AsBlank` errors in Rails 8.1 by ensuring all LinkedinUrlValue types (Regular, Exceptional, AsBlank) can be serialized.

## [0.2.3] - 2026-01-02

### Changed
Expand Down
2 changes: 1 addition & 1 deletion lib/linkedin_url_value/job_serializer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def klass
end

def serialize?(argument)
argument.is_a?(klass)
argument.is_a?(LinkedinUrlValue::Base)
end

def serialize(value)
Expand Down
2 changes: 1 addition & 1 deletion linkedin_url_value.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Gem::Specification.new do |spec|
spec.name = "linkedin_url_value"
spec.version = "0.2.3"
spec.version = "0.2.4"
spec.authors = ["Grant Petersen-Speelman"]
spec.email = ["grant@nexl.io"]

Expand Down