Fix JobSerializer klass method to return Regular instead of Base #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update klass method to return LinkedinUrlValue::Regular since Rails job serialization uses an index hash where Base (abstract class) never matches - Bump version to 0.2.3 - Update CHANGELOG.md Co-Authored-By: Grant <grantspeelman@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Pull request overview
This PR fixes the JobSerializer#klass method to return the concrete LinkedinUrlValue::Regular class instead of the abstract LinkedinUrlValue::Base class, ensuring proper Rails job serialization. The version is bumped to 0.2.3.
- Fixed
JobSerializer#klassto returnRegularinstead ofBasefor proper serialization - Updated version from 0.2.2 to 0.2.3
- Added changelog entry documenting the fix
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| linkedin_url_value.gemspec | Bumps gem version to 0.2.3 |
| lib/linkedin_url_value/job_serializer.rb | Changes klass method to return Regular instead of Base class |
| CHANGELOG.md | Adds entry for version 0.2.3 documenting the serializer fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
grantspeelman
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
JobSerializer#klassmethod to returnLinkedinUrlValue::Regularinstead ofLinkedinUrlValue::Base. Rails job serialization uses an index hash whereBase(an abstract class) will never match, so the serializer now returns the concreteRegularclass. Also bumps version to 0.2.3.Notes
Link to Devin run: https://app.devin.ai/sessions/13e09c0d06574583a7bf39fc3f68ddca
Requested by: Grant (grant@nexl.io)