Add RestClient::Gone exception handling to return nil #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds RestClient::Gone to existing rescue clause alongside NotFound and UnprocessableEntity - Follows same pattern of returning nil for these HTTP error conditions - Fixes rollbar error for Gone (410) responses from FullContact API Co-Authored-By: Grant <machine.user@nexl.io>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Adds test case for HTTP 410 Gone responses returning nil - Follows existing test pattern using WebMock to stub exception - Verifies RestClient::Gone is handled consistently with other exceptions Co-Authored-By: Grant <machine.user@nexl.io>
- Update version from 0.3.2 to 0.4.0 in lib/fc_enrich/version.rb - Add CHANGELOG entry for 0.4.0 documenting RestClient::Gone exception handling - Add test coverage entry in changelog Co-Authored-By: Grant <machine.user@nexl.io>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds handling for HTTP 410 Gone responses from the FullContact API by treating them the same as 404 and 422 errors (returning nil instead of raising an exception). This fixes a Rollbar error when the API returns a 410 status code.
- Added
RestClient::Goneto the rescue clause inHttpClient#postmethod - Added test coverage for the new exception handling
- Updated version to 0.4.0 with changelog entry
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/fc_enrich/http_client.rb | Added RestClient::Gone to existing rescue clause to return nil for 410 responses |
| spec/fc_enrich/http_client_spec.rb | Added test case to verify 410 Gone responses return nil |
| lib/fc_enrich/version.rb | Bumped version from 0.3.2 to 0.4.0 |
| CHANGELOG.md | Added changelog entry for version 0.4.0 describing the new functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
grantspeelman
approved these changes
Sep 26, 2025
grantspeelman
deleted the
devin/1727376854-add-restclient-gone-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For fixing https://app.rollbar.com/a/NEXL-LTS/fix/item/entity-office/1805
Added
RestClient::Gone(HTTP 410) to the existing rescue clause inHttpClient#postthat returnsnilfor API errors. This change aligns with the current handling ofRestClient::NotFound(404) andRestClient::UnprocessableEntity(422) errors and resolves a rollbar error when the FullContact API returns a 410 Gone response.The changes include:
lib/fc_enrich/http_client.rbspec/fc_enrich/http_client_spec.rbLink to Devin run: https://app.devin.ai/sessions/1f00aa748b2347048ba8e3934e448e16
Requested by: Grant (@nexlbot)