Fix duplicate incidentId problem in loggingservice.yaml per STA-010.3b #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Removed duplicate incidentId in IncidentMergeLogEvent, IncidentUnmergeLogEvent, IncidentLinkLogEvent, and the IncidentUnLinkLogEvent. 2. Made the names match STA-010.3b for the members that represent the second incident id in these LogEvents. Corrected the camel case of "IncidentIdunlinkedFrom", changed it to "IncidentIdUnLinkedFrom". Must be fixed in 3b text. 3. DID NOT edit IncidentSplitLogEvent, which also has the duplicate incidentId problem, because the text in 3b doesn't specify a new name for the second incident id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STA-0103b fixed the duplicate incidentId problem in the text, but the yaml was never corrected. This version corrects the yaml: