Conversation
…y a test and a bunch of "FIXME:ENUM" messages to be investigated. This absolutely does not work as is because the DataTypeMessage dtype is misinterpreted as a vlen sequence. But it's a starting point.
…ted it or anything ... yet ... but the right answer will be something like this.
… length is multiple of 8
…we have to decide how much of the h5py DataType (and possibly h5t.TypeNumID) we want to implement.
… when the datatype is enumeration.
… not pyfive or h5py is right here. Compare with netcdf4-python?
Includes Brian's pull request to simplify workflow from here.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 71.93% 72.58% +0.65%
==========================================
Files 11 11
Lines 2423 2499 +76
Branches 364 379 +15
==========================================
+ Hits 1743 1814 +71
Misses 583 583
- Partials 97 102 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@bnlawrence you are fine wrt coverage see https://app.codecov.io/gh/NCAS-CMS/pyfive/tree/enum_and_friends - it's just that your HEAD was off a different branch (Kai's branch that had evolved in the meantime), but Codecov looked at that initial state branch to compare; it's always a good idea to start your work off the latest |
valeriupredoi
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR provides support for Enumeration datatypes, both as standalone datatypes, and as datatypes used directly within integer enumerations.
Closes #85
Checklist