Skip to content

Enumeration Support#93

Merged
valeriupredoi merged 21 commits intomainfrom
enum_and_friends
Sep 16, 2025
Merged

Enumeration Support#93
valeriupredoi merged 21 commits intomainfrom
enum_and_friends

Conversation

@bnlawrence
Copy link
Collaborator

@bnlawrence bnlawrence commented Sep 1, 2025

Description

This PR provides support for Enumeration datatypes, both as standalone datatypes, and as datatypes used directly within integer enumerations.

Closes #85

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

Bryan Lawrence and others added 20 commits August 20, 2025 08:29
…y a test and a bunch of "FIXME:ENUM" messages to be investigated. This absolutely does not work as is because the DataTypeMessage dtype is misinterpreted as a vlen sequence. But it's a starting point.
…ted it or anything ... yet ... but the right answer will be something like this.
…we have to decide how much of the h5py DataType (and possibly h5t.TypeNumID) we want to implement.
… not pyfive or h5py is right here. Compare with netcdf4-python?
Includes Brian's pull request to simplify workflow from here.
@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 84.07080% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.58%. Comparing base (04f5199) to head (4a5dede).
⚠️ Report is 217 commits behind head on main.

Files with missing lines Patch % Lines
pyfive/h5t.py 62.96% 9 Missing and 1 partial ⚠️
pyfive/dataobjects.py 72.22% 2 Missing and 3 partials ⚠️
pyfive/h5d.py 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   71.93%   72.58%   +0.65%     
==========================================
  Files          11       11              
  Lines        2423     2499      +76     
  Branches      364      379      +15     
==========================================
+ Hits         1743     1814      +71     
  Misses        583      583              
- Partials       97      102       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@valeriupredoi
Copy link
Collaborator

@bnlawrence you are fine wrt coverage see https://app.codecov.io/gh/NCAS-CMS/pyfive/tree/enum_and_friends - it's just that your HEAD was off a different branch (Kai's branch that had evolved in the meantime), but Codecov looked at that initial state branch to compare; it's always a good idea to start your work off the latest main

@valeriupredoi valeriupredoi merged commit 673d241 into main Sep 16, 2025
5 of 6 checks passed
@valeriupredoi valeriupredoi deleted the enum_and_friends branch September 16, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Enumerated Data Types

3 participants