Conversation
|
@kmuehlbauer think these are all the ones from #81 mate, many thanks 🍻 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 71.93% 71.93%
=======================================
Files 11 11
Lines 2423 2423
Branches 364 364
=======================================
Hits 1743 1743
Misses 583 583
Partials 97 97 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| #### The following method can be used to set pseudo chunking size after the | ||
| #### file has been closed and before data transactions. This is pyfive specific | ||
| def set_psuedo_chunk_size(self, newsize_MB): | ||
| def set_pseudo_chunk_size(self, newsize_MB): |
There was a problem hiding this comment.
@bnlawrence was well thorough - he wrore psuedo in the test call too 🤣
There was a problem hiding this comment.
At least I got the test name right ... I think ... :-)
| var1 = f['var1'] | ||
| # use 100 KB as the chunk size | ||
| var1.id.set_psuedo_chunk_size(0.1) | ||
| var1.id.set_pseudo_chunk_size(0.1) |
There was a problem hiding this comment.
@bnlawrence no, they were both wrong, that's why the test was passing 🤣
There was a problem hiding this comment.
ah the the test name -> yes, sorry, my bda 😁
|
@kmuehlbauer if you got a minute to approve, pls, this will go in too, just in time for Friday pub o'clock here 🍻 |
|
Great! Thanks for doing this Valeriu! |
|
Many thanks, Kai! 🍺 |
3 participants
Description
Ported review suggestions by @kmuehlbauer on
#81 since that was a closed and merged PR 🍺
Before you get started
Checklist