Add __orthogonal_indexing__ flag#182
Merged
davidhassell merged 10 commits intoNCAS-CMS:mainfrom Jan 29, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
- Coverage 77.33% 77.33% -0.01%
==========================================
Files 15 15
Lines 2974 2982 +8
Branches 477 479 +2
==========================================
+ Hits 2300 2306 +6
- Misses 555 556 +1
- Partials 119 120 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bnlawrence
approved these changes
Jan 23, 2026
Collaborator
bnlawrence
left a comment
There was a problem hiding this comment.
This is consistent with the discussion
valeriupredoi
approved these changes
Jan 27, 2026
Collaborator
valeriupredoi
left a comment
There was a problem hiding this comment.
LGTM with many thanks! @davidhassell please merge at will 🍺
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
__orthogonal_indexing__flag to theDatasetclass.Closes #171
Before you get started
Checklist