Skip to content

Add __orthogonal_indexing__ flag#182

Merged
davidhassell merged 10 commits intoNCAS-CMS:mainfrom
davidhassell:orthogonal-indexing-flag
Jan 29, 2026
Merged

Add __orthogonal_indexing__ flag#182
davidhassell merged 10 commits intoNCAS-CMS:mainfrom
davidhassell:orthogonal-indexing-flag

Conversation

@davidhassell
Copy link
Collaborator

Description

Add __orthogonal_indexing__ flag to the Dataset class.

Closes #171

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.33%. Comparing base (edcc2d0) to head (08827b6).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
pyfive/high_level.py 75.00% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   77.33%   77.33%   -0.01%     
==========================================
  Files          15       15              
  Lines        2974     2982       +8     
  Branches      477      479       +2     
==========================================
+ Hits         2300     2306       +6     
- Misses        555      556       +1     
- Partials      119      120       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@bnlawrence bnlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with the discussion

Copy link
Collaborator

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with many thanks! @davidhassell please merge at will 🍺

@davidhassell davidhassell merged commit 8013de9 into NCAS-CMS:main Jan 29, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add __orthogonal_indexing__ flag

3 participants