Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 77.33% 77.33%
=======================================
Files 15 15
Lines 2974 2974
Branches 477 477
=======================================
Hits 2300 2300
Misses 555 555
Partials 119 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@kmuehlbauer @davidhassell any of you good folks has a minute to review this, please 🍻 |
bnlawrence
left a comment
There was a problem hiding this comment.
I have no idea how to review this. This seems pretty exhaustive of what a developer might accidentally put inside the repo, but I guess there is an infinity of possibilities here.
Given that I can't see anything we'd want to go through that is being avoided , and there (and if such a thing were to happen, any modern IDE should flag it up, and the gitignore could be updated), and the inverse is true (anything that sneaks in can be removed and gitignore updated), i think this works for me.
|
many thanks @bnlawrence for revieweing, and @dostuffthatmatters for the great suggestions! 🍻 |
Description
Closes #167
This PR adds both a more inclusive, and a more structured
.gitignore. In response to JOSS paper review - and with many thanks!Before you get started
Checklist