Skip to content

Overhaul .gitignore file#179

Merged
valeriupredoi merged 5 commits intomainfrom
overhaul_gitignore
Jan 27, 2026
Merged

Overhaul .gitignore file#179
valeriupredoi merged 5 commits intomainfrom
overhaul_gitignore

Conversation

@valeriupredoi
Copy link
Collaborator

@valeriupredoi valeriupredoi commented Jan 14, 2026

Description

Closes #167

This PR adds both a more inclusive, and a more structured .gitignore. In response to JOSS paper review - and with many thanks!

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.33%. Comparing base (edcc2d0) to head (8cb8467).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   77.33%   77.33%           
=======================================
  Files          15       15           
  Lines        2974     2974           
  Branches      477      477           
=======================================
  Hits         2300     2300           
  Misses        555      555           
  Partials      119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@valeriupredoi
Copy link
Collaborator Author

@kmuehlbauer @davidhassell any of you good folks has a minute to review this, please 🍻

Copy link
Collaborator

@bnlawrence bnlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how to review this. This seems pretty exhaustive of what a developer might accidentally put inside the repo, but I guess there is an infinity of possibilities here.

Given that I can't see anything we'd want to go through that is being avoided , and there (and if such a thing were to happen, any modern IDE should flag it up, and the gitignore could be updated), and the inverse is true (anything that sneaks in can be removed and gitignore updated), i think this works for me.

@valeriupredoi
Copy link
Collaborator Author

many thanks @bnlawrence for revieweing, and @dostuffthatmatters for the great suggestions! 🍻

@valeriupredoi valeriupredoi merged commit 78fa31f into main Jan 27, 2026
7 checks passed
@valeriupredoi valeriupredoi deleted the overhaul_gitignore branch January 27, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JOSS REVIEW]: Extend .gitignore

2 participants