Skip to content

Fix display of p5dump global attributes#163

Merged
valeriupredoi merged 1 commit intoNCAS-CMS:mainfrom
zequihg50:p5dump-bad-global-attr-name
Dec 18, 2025
Merged

Fix display of p5dump global attributes#163
valeriupredoi merged 1 commit intoNCAS-CMS:mainfrom
zequihg50:p5dump-bad-global-attr-name

Conversation

@zequihg50
Copy link
Contributor

@zequihg50 zequihg50 commented Dec 17, 2025

Fixes #162 by including the name as part of the inner function.

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.83%. Comparing base (a83d389) to head (c8b685f).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   76.83%   76.83%           
=======================================
  Files          15       15           
  Lines        2936     2936           
  Branches      467      467           
=======================================
  Hits         2256     2256           
  Misses        558      558           
  Partials      122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@valeriupredoi
Copy link
Collaborator

valeriupredoi commented Dec 17, 2025

thanks @zequihg50 - could you please rename the PR to something a bit more descriptive, and add a wee bit of description in the PR description - there's a reason for those boxes to be checked, that you removed 😁

@zequihg50 zequihg50 changed the title Fixes #162 Fix display of p5dump global attributes Dec 17, 2025
@zequihg50 zequihg50 marked this pull request as draft December 17, 2025 15:54
@zequihg50 zequihg50 marked this pull request as ready for review December 17, 2025 15:55
Copy link
Collaborator

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks, Zeki! 🍺 @bnlawrence do you have a minute to look this over quickly, and merge, plss

@valeriupredoi
Copy link
Collaborator

many thanks @zequihg50 - verbal approve from @bnlawrence too, so this is going in now

@valeriupredoi valeriupredoi merged commit a8e706a into NCAS-CMS:main Dec 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

p5dumps displays last variable's name in global attributes

2 participants