Fix display of p5dump global attributes#163
Merged
valeriupredoi merged 1 commit intoNCAS-CMS:mainfrom Dec 18, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
=======================================
Coverage 76.83% 76.83%
=======================================
Files 15 15
Lines 2936 2936
Branches 467 467
=======================================
Hits 2256 2256
Misses 558 558
Partials 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
thanks @zequihg50 - could you please rename the PR to something a bit more descriptive, and add a wee bit of description in the PR description - there's a reason for those boxes to be checked, that you removed 😁 |
valeriupredoi
approved these changes
Dec 17, 2025
Collaborator
valeriupredoi
left a comment
There was a problem hiding this comment.
many thanks, Zeki! 🍺 @bnlawrence do you have a minute to look this over quickly, and merge, plss
Collaborator
|
many thanks @zequihg50 - verbal approve from @bnlawrence too, so this is going in now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #162 by including the
nameas part of the inner function.