Merged
Conversation
added 2 commits
November 10, 2025 15:41
Collaborator
Author
|
We also need to make sure #149 is done! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
+ Coverage 76.21% 76.26% +0.05%
==========================================
Files 14 14
Lines 2867 2869 +2
Branches 450 451 +1
==========================================
+ Hits 2185 2188 +3
Misses 561 561
+ Partials 121 120 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 2 commits
November 10, 2025 16:28
Collaborator
|
@bnlawrence #140 is now closed 🍻 |
valeriupredoi
approved these changes
Nov 12, 2025
Collaborator
|
@kmuehlbauer we caught that test from #140 fail, but this time around with a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the clean up pull request for the final things for pyfive 1.0
At this point there are only two outstanding issues: #140 and #137.
When this is complete, both should be closed.
For now, this closes #137.
@valeriupredoi: can you please sort out #140 or make a decision to move it to the Milestone 2.0 collection.
Checklist