Skip to content

Milestone 1p0#148

Merged
valeriupredoi merged 5 commits intomainfrom
ms1p0
Nov 12, 2025
Merged

Milestone 1p0#148
valeriupredoi merged 5 commits intomainfrom
ms1p0

Conversation

@bnlawrence
Copy link
Collaborator

This is the clean up pull request for the final things for pyfive 1.0
At this point there are only two outstanding issues: #140 and #137.
When this is complete, both should be closed.
For now, this closes #137.
@valeriupredoi: can you please sort out #140 or make a decision to move it to the Milestone 2.0 collection.

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

@bnlawrence bnlawrence added this to the 1.0 milestone Nov 10, 2025
@bnlawrence
Copy link
Collaborator Author

We also need to make sure #149 is done!

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.26%. Comparing base (5f79b82) to head (b9ef8c4).
⚠️ Report is 194 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   76.21%   76.26%   +0.05%     
==========================================
  Files          14       14              
  Lines        2867     2869       +2     
  Branches      450      451       +1     
==========================================
+ Hits         2185     2188       +3     
  Misses        561      561              
+ Partials      121      120       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@valeriupredoi
Copy link
Collaborator

@bnlawrence #140 is now closed 🍻

@valeriupredoi
Copy link
Collaborator

valeriupredoi commented Nov 12, 2025

@kmuehlbauer we caught that test from #140 fail, but this time around with a TypeError https://github.com/NCAS-CMS/pyfive/actions/runs/19300769569/job/55194338618?pr=148 hence it failed-failed, with no reruns

@valeriupredoi valeriupredoi merged commit e434584 into main Nov 12, 2025
6 of 7 checks passed
@valeriupredoi valeriupredoi deleted the ms1p0 branch November 12, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

current versions of pyfive (0.5-0.9) assume a v1 btree for chunked data and never check

2 participants