Added btree v2 test but skipping it (#137)#143
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 76.21% 76.01% -0.20%
==========================================
Files 14 14
Lines 2867 2877 +10
Branches 450 454 +4
==========================================
+ Hits 2185 2187 +2
- Misses 561 569 +8
Partials 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We have both a file, and code to create a file? Do we think we should do both, rather than over-write it in the fixture (if that's what happens)? Maybe test both the original and the fixture version so can be sure that we work with the file we created, and work with the files that will be created? |
|
Testing both the original and the fixture looks good to me too. I will make the changes. |
|
Does this make sense? Please feel free to edit as necessary. |
|
@valeriupredoi I think we can merge this, it'll put is in a good place for V2. Thanks @zequihg50. |
|
OMG, I just force-pushed to main... my bad. I’ll fix it tomorrow. Lesson learned: always use feature branches. |
nice try, Sherlock! You can't force push to |
sure thing! I'll have a look tomorrow 🍺 |
|
Fixed, apologies again. |
valeriupredoi
left a comment
There was a problem hiding this comment.
many thanks @zequihg50 🍻
Refer to #137 for further details.