Skip to content

Added btree v2 test but skipping it (#137)#143

Merged
valeriupredoi merged 2 commits intoNCAS-CMS:mainfrom
zequihg50:main
Nov 5, 2025
Merged

Added btree v2 test but skipping it (#137)#143
valeriupredoi merged 2 commits intoNCAS-CMS:mainfrom
zequihg50:main

Conversation

@zequihg50
Copy link
Contributor

Refer to #137 for further details.

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.01%. Comparing base (bac7664) to head (366a045).

Files with missing lines Patch % Lines
pyfive/high_level.py 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   76.21%   76.01%   -0.20%     
==========================================
  Files          14       14              
  Lines        2867     2877      +10     
  Branches      450      454       +4     
==========================================
+ Hits         2185     2187       +2     
- Misses        561      569       +8     
  Partials      121      121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bnlawrence
Copy link
Collaborator

We have both a file, and code to create a file? Do we think we should do both, rather than over-write it in the fixture (if that's what happens)? Maybe test both the original and the fixture version so can be sure that we work with the file we created, and work with the files that will be created?

@zequihg50
Copy link
Contributor Author

Testing both the original and the fixture looks good to me too. I will make the changes.

@zequihg50
Copy link
Contributor Author

Does this make sense? Please feel free to edit as necessary.

@bnlawrence
Copy link
Collaborator

@valeriupredoi I think we can merge this, it'll put is in a good place for V2. Thanks @zequihg50.

@zequihg50
Copy link
Contributor Author

OMG, I just force-pushed to main... my bad. I’ll fix it tomorrow. Lesson learned: always use feature branches.

@valeriupredoi
Copy link
Collaborator

valeriupredoi commented Nov 4, 2025

OMG, I just force-pushed to main... my bad. I’ll fix it tomorrow. Lesson learned: always use feature branches.

nice try, Sherlock! You can't force push to main, you force-pushed main here, ie performed a benign merge main into feature branch - which is quite welcome too 😃

@valeriupredoi
Copy link
Collaborator

@valeriupredoi I think we can merge this, it'll put is in a good place for V2. Thanks @zequihg50.

sure thing! I'll have a look tomorrow 🍺

@zequihg50
Copy link
Contributor Author

Fixed, apologies again.

Copy link
Collaborator

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks @zequihg50 🍻

@valeriupredoi valeriupredoi merged commit c8e2f68 into NCAS-CMS:main Nov 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants