Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 74.03% 74.13% +0.09%
==========================================
Files 11 11
Lines 2596 2606 +10
Branches 406 408 +2
==========================================
+ Hits 1922 1932 +10
- Misses 565 566 +1
+ Partials 109 108 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It is impressive how straightforward this is compared to compiling a dynamic link library and loading it at runtime, as is needed when using plugins with the C library. |
|
@bmaranville I really thought, can it be that easy?, by looking at the gzip above. |
|
the DLL is still there, but conda-forge compiled packages are the stuff of dreams 😁 |
valeriupredoi
left a comment
There was a problem hiding this comment.
spiffy, and with very many thanks as ever, @kmuehlbauer 🍺 @bnlawrence wanna have a final look and merge, please? 🍺
bnlawrence
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!!!
Description
As described in #89 we want to add more decompression filters. LZF is used within the xarray testsuite and by implementing this will fix the xarray testsuite for the H5NetCDF related tests.
This also serves as a blueprint for other filters (blosc, lzma etc.).
Before you get started
Checklist