Skip to content

remove pin on netcdf4#126

Merged
valeriupredoi merged 1 commit intomainfrom
remove_netcdf4_pin
Oct 16, 2025
Merged

remove pin on netcdf4#126
valeriupredoi merged 1 commit intomainfrom
remove_netcdf4_pin

Conversation

@valeriupredoi
Copy link
Collaborator

@valeriupredoi valeriupredoi commented Oct 16, 2025

Description

netCDF4==1.7.3 built and deployed on conda-forge so we need to remove the pin in pyproject.toml since now we end up with an older package, and from PyPI on top of it

https://anaconda.org/conda-forge/netcdf4

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Any changed dependencies have been added or removed correctly (if need be)
  • All tests pass

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.05%. Comparing base (1ef1af4) to head (19f71f6).
⚠️ Report is 106 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   74.05%   74.05%           
=======================================
  Files          11       11           
  Lines        2598     2598           
  Branches      406      406           
=======================================
  Hits         1924     1924           
  Misses        565      565           
  Partials      109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kmuehlbauer
Copy link
Collaborator

Seems everything is nice on conda-forge 🥇

@valeriupredoi
Copy link
Collaborator Author

in conda-forge we trust 😁 Cheers, @kmuehlbauer 🍺

@valeriupredoi valeriupredoi merged commit cce3d0b into main Oct 16, 2025
7 checks passed
@valeriupredoi valeriupredoi deleted the remove_netcdf4_pin branch October 16, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants