Merged
Conversation
added 3 commits
October 5, 2025 09:03
…sting around edge cases, and the docuemenation, and should be done.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 73.32% 74.05% +0.73%
==========================================
Files 11 11
Lines 2575 2598 +23
Branches 401 406 +5
==========================================
+ Hits 1888 1924 +36
+ Misses 580 565 -15
- Partials 107 109 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kmuehlbauer
reviewed
Oct 6, 2025
Collaborator
kmuehlbauer
left a comment
There was a problem hiding this comment.
@bnlawrence This looks like a nice addition. I've added a couple comments and suggestions.
Co-authored-by: Kai Mühlbauer <kmuehlbauer@wradlib.org>
Collaborator
|
very many thanks @bnlawrence and @kmuehlbauer 🍻 |
valeriupredoi
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for opaque datasets, or at least those written by h5py. Would need some real test files written by someone else to check full support (but I am hopeful it would work).
Closes #88
Closes #70
Checklist