Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds piping infrastructure to enable chaining commands together using the :: operator, specifically allowing drsview to pipe its output to other commands like ls. The implementation includes caching mechanisms to avoid expensive recomputation and adds defensive null-checking throughout the codebase.
Changes:
- Added
drsviewto pipe producers andlsto pipe consumers - Implemented output caching in
do_drsviewto support piping - Enhanced
do_lsto consume piped input from other commands - Added defensive null checks for object attributes throughout the codebase
- Made docker dependency optional for tests that don't require MinIO
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 16 comments.
| File | Description |
|---|---|
| tests/test_piping.py | New test file covering pipe functionality between drsview and ls commands |
| tests/conftest.py | Made docker import optional to allow running tests without Docker installed |
| pyproject.toml | Added udunits2 as a new dependency |
| cfs3/s3cmd.py | Core implementation of piping infrastructure, output caching, and defensive programming enhancements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
looks like you're in decent hands here @bnlawrence 😆 |
Contributor
Author
|
I accidentally put the #22 over top of this rather than branch, and it's too much hassle to unpick , so we'll pick this up there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is that we want to be able to go from a drsview to specific files (this was possible before, but this is an exercise in building up the piping infrastructure as well as adding a different route to functionality).