Fix bug where cf.Field.subspace doesn't always correctly handle global cyclic subspaces#830
Merged
davidhassell merged 15 commits intoNCAS-CMS:mainfrom Nov 14, 2024
Merged
Conversation
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
Lots of confusing talk of wardrobes (see in-line comments 😄) here, otherwise all good in that the fix works with good implementation and new testing coverage, but I think we have the case of a without/wo query to also fix up in a similar way (see my in-line comment with the code snippet example) so please check that comment and let me know what you think.
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
sadielbartholomew
approved these changes
Nov 11, 2024
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
Thanks for addressing my feedback. I've done a final sanity check after the new commits. All good, please merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #828.
This PR fixes and simplifies the treatment of cyclic subspaces in
cf.mixin.fielddomain._indices. In the process, it refactorscf.mixin.fielddomain.anchorby moving the business-end of that to the newcf.DimensionCoordinate.anchor. This new method also allows for "cell" anchoring, which we might like to use later (see #824).