Skip to content

Unpin depependencies#9

Merged
valeriupredoi merged 7 commits intomainfrom
unpin_deps
Sep 29, 2022
Merged

Unpin depependencies#9
valeriupredoi merged 7 commits intomainfrom
unpin_deps

Conversation

@valeriupredoi
Copy link
Collaborator

Tested locally, works fine! Let's see what it does on the CI...

@valeriupredoi valeriupredoi added the enhancement New feature or request label Sep 29, 2022
@valeriupredoi valeriupredoi changed the title Unpin depependencie and remove h5py from the deps list Unpin depependencies and remove h5py from the deps list Sep 29, 2022
@valeriupredoi
Copy link
Collaborator Author

Proves out the h5py dependency is still needed, even if it's not a direct dependency of ours, but rather, kerchunk's, I opened an issue asking them to get all their direct deps in one basked to be pulled in via the conda package fsspec/kerchunk#224 - we'll remove it when they do that, in the meantime I am re-adding it 👍

@valeriupredoi valeriupredoi changed the title Unpin depependencies and remove h5py from the deps list Unpin depependencies ~and remove h5py from the deps list~ Sep 29, 2022
@valeriupredoi valeriupredoi changed the title Unpin depependencies ~and remove h5py from the deps list~ Unpin depependencies Sep 29, 2022
@valeriupredoi
Copy link
Collaborator Author

Nevermind, I moved the h5py/kerchunk issue to the right place in their feedstock repo conda-forge/kerchunk-feedstock#4

@valeriupredoi
Copy link
Collaborator Author

all checks out here 🥳

@valeriupredoi valeriupredoi merged commit 620d15c into main Sep 29, 2022
@valeriupredoi valeriupredoi deleted the unpin_deps branch September 29, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant