Lint code in activestorage/ and add flake8 test at push#281
Merged
valeriupredoi merged 17 commits intomainfrom Jul 17, 2025
Merged
Lint code in activestorage/ and add flake8 test at push#281valeriupredoi merged 17 commits intomainfrom
activestorage/ and add flake8 test at push#281valeriupredoi merged 17 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 85.20% 85.98% +0.77%
==========================================
Files 7 7
Lines 649 642 -7
==========================================
- Hits 553 552 -1
+ Misses 96 90 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Ive decided to skip black -ing the code, too specific a formatter for now, so will just pylint with yapf instead, minimal approach 🤏 |
Collaborator
Author
|
cov variation is OK - we're covered by "slow" tests that are skipped - the actual absolute coverage increases by 0.8% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #231
I linted all the code in the main source
activestorage/and added a flake8 test at push.@davidhassell I'd like a review on this one please, when you have a minute (ie am not gonna barge-merge it like other PRs that were purely functional), the linting is via black, but am not popping black in just yet, I think I'll let flake8 detect any incoming issues for now. What do you think?
Before you get started
Checklist