Handy attribute/numpy-like statistics and mark real (S3, https) tests to slow#253
Merged
valeriupredoi merged 22 commits intomainfrom Apr 11, 2025
Merged
Handy attribute/numpy-like statistics and mark real (S3, https) tests to slow#253valeriupredoi merged 22 commits intomainfrom
slow#253valeriupredoi merged 22 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
- Coverage 91.18% 85.07% -6.11%
==========================================
Files 7 7
Lines 635 650 +15
==========================================
- Hits 579 553 -26
- Misses 56 97 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@davidhassell cheers for the (verbal) review, I think I've plopped all in here for an actual review, please 🍻 |
slow
Collaborator
Author
|
great many thanks @davidhassell 🍺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributes towards #231
A more convenient way to handle stats:
File
Dataset
Note thecomponentsattr is all under the hood now.The
componentsattr is back again at the user's discretion, thanks to @davidhassell pointing out that's actually needed to be variable.Also, I made the real S3 and https tests
slow, and the GHA is now skipping them only for a PR (it runs them when we merge, and nightly). It's incredible how much variability there is in terms of running a set of such simple tests, with times ranging from a couple minutes to even 20-30min; network load is bloody big!Skipping the https tests via
slowdecreases our measured coverage by 6% (from almost 92% to 86%), but that's fine, we actually run them, codecov measures coverage off the tests run in the PR.Before you get started
Checklist