Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[download] Erroneous urls should return url not found #431

Open
aaperis opened this issue Aug 22, 2024 · 0 comments
Open

[download] Erroneous urls should return url not found #431

aaperis opened this issue Aug 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@aaperis
Copy link
Contributor

aaperis commented Aug 22, 2024

How to reproduce:

./sda-cli list --config s3cmd-bp.conf -url https://whatever.bp.nbis.se -datasets
The provided access token expires in 719h33m2s
Error: failed to get datasets, reason: failed to get response, reason: Get "https://whatever.bp.nbis.se/metadata/datasets": tls: failed to verify certificate: x509: certificate is valid for ingress.local, not whatever.bp.nbis.se

and

./sda-cli list --config s3cmd-bp.conf -url https://whatever.nbis.se -datasets
The provided access token expires in 719h32m53s
Error: failed to get datasets, reason: failed to get response, reason: Get "https://whatever.nbis.se/metadata/datasets": dial tcp: lookup whatever.nbis.se: no such host

Expected behavior:

  • All erroneous urls should not propagate internal errors to the user but return url not found instead.
@aaperis aaperis added the bug Something isn't working label Aug 22, 2024
@aaperis aaperis changed the title [download] Erroneous urls should not be handled differently depending on the subdomain. [download] Erroneous urls should return url not found Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant