Skip to content

Comments

Photolysis rates update#425

Merged
mkelley merged 8 commits intoNASA-Planetary-Science:mainfrom
mkelley:photolysis-rates-2025.09
Oct 17, 2025
Merged

Photolysis rates update#425
mkelley merged 8 commits intoNASA-Planetary-Science:mainfrom
mkelley:photolysis-rates-2025.09

Conversation

@mkelley
Copy link
Member

@mkelley mkelley commented Sep 5, 2025

  • Add new photolysis rates for H2O and CO2 from Huebner & Mukherjee 2015.
  • Reformat photo_timescale and photo_lengthscale exception messages to show a nice table.
  • Require source for photo_timescale and photo_lengthscale (and subsequently productionrate.beta_factor).
  • Light code reformatting.

@github-actions
Copy link

github-actions bot commented Sep 5, 2025

Thank you for your contribution to sbpy, an Astropy affiliated package! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the sbpy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label.
  • Is a milestone added?

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 59.78552% with 150 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.66%. Comparing base (dac9a95) to head (427f043).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
sbpy/activity/gas/tests/test_prodrate_remote.py 2.54% 115 Missing ⚠️
sbpy/activity/gas/productionrate.py 62.76% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
+ Coverage   84.60%   84.66%   +0.06%     
==========================================
  Files          92       92              
  Lines        8425     8453      +28     
==========================================
+ Hits         7128     7157      +29     
+ Misses       1297     1296       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkelley
Copy link
Member Author

mkelley commented Sep 26, 2025

After hearing some comments at the EPSC/DPS meeting this year, I am making source a required parameter for photo_timescale and photo_lengthscale. This will avoid inadvertently mixing scales from different sources, which can have scientific consequences.

@mkelley
Copy link
Member Author

mkelley commented Sep 26, 2025

The codecov test fails because I reformatted the productionrate.py file, but that file doesn't have good coverage in the tests. I think we can proceed without this passing.

@mkelley mkelley requested a review from hhsieh00 September 26, 2025 15:44
Copy link
Collaborator

@hhsieh00 hhsieh00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@mkelley mkelley merged commit 14cc083 into NASA-Planetary-Science:main Oct 17, 2025
9 of 10 checks passed
@mkelley mkelley deleted the photolysis-rates-2025.09 branch October 17, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants