Skip to content

Comments

Bugfix RA column unit in sbpy-ephem CLI script.#424

Merged
mkelley merged 2 commits intoNASA-Planetary-Science:mainfrom
mkelley:ephem-cli-unit-fix-2025.03
Aug 29, 2025
Merged

Bugfix RA column unit in sbpy-ephem CLI script.#424
mkelley merged 2 commits intoNASA-Planetary-Science:mainfrom
mkelley:ephem-cli-unit-fix-2025.03

Conversation

@mkelley
Copy link
Member

@mkelley mkelley commented Mar 25, 2025

RA columns were displayed as units of "deg" despite being units of "hourangle" (as requested).

Was:

(scipy) msk@notwo:~$ sbpy-ephem mpc "C/2022 R6" --start=2022-08-07 --end=2022-08-08 --step=1h
# requested target: C/2022 R6
# returned target: C/2022 R6
# location: 500
          date              RA         Dec       rh  delta phase solarelong  V   Proper motion Direction
                           deg         deg       AU    AU   deg     deg     mag    arcsec / h     deg   
----------------------- ---------- ----------- ----- ----- ----- ---------- ---- ------------- ---------
2022-08-07 00:00:00.000 3:34:49.10 -36:10:30.0 9.741 9.614   6.0       94.2 19.8         14.49     141.8
2022-08-07 01:00:00.000 3:34:49.80 -36:10:41.0 9.741 9.614   6.0       94.2 19.8         14.49     141.8
2022-08-07 02:00:00.000 3:34:50.60 -36:10:52.0 9.741 9.613   6.0       94.3 19.8         14.49     141.8
2022-08-07 03:00:00.000 3:34:51.30 -36:11:04.0 9.741 9.612   6.0       94.3 19.8         14.49     141.9
2022-08-07 04:00:00.000 3:34:52.10 -36:11:15.0  9.74 9.612   6.0       94.3 19.8         14.49     141.9
2022-08-07 05:00:00.000 3:34:52.80 -36:11:27.0  9.74 9.611   6.0       94.3 19.8         14.48     142.0
2022-08-07 06:00:00.000 3:34:53.50 -36:11:38.0  9.74 9.611   6.0       94.3 19.8         14.48     142.0
2022-08-07 07:00:00.000 3:34:54.30 -36:11:49.0  9.74  9.61   6.0       94.4 19.8         14.48     142.0

Now:

(scipy) msk@notwo:~$ sbpy-ephem mpc "C/2022 R6" --start=2022-08-07 --end=2022-08-08 --step=1h
# requested target: C/2022 R6
# returned target: C/2022 R6
# location: 500
          date              RA         Dec       rh  delta phase solarelong  V   Proper motion Direction
                        hourangle      deg       AU    AU   deg     deg     mag    arcsec / h     deg   
----------------------- ---------- ----------- ----- ----- ----- ---------- ---- ------------- ---------
2022-08-07 00:00:00.000 3:34:49.10 -36:10:30.0 9.741 9.614   6.0       94.2 19.8         14.49     141.8
2022-08-07 01:00:00.000 3:34:49.80 -36:10:41.0 9.741 9.614   6.0       94.2 19.8         14.49     141.8
2022-08-07 02:00:00.000 3:34:50.60 -36:10:52.0 9.741 9.613   6.0       94.3 19.8         14.49     141.8
2022-08-07 03:00:00.000 3:34:51.30 -36:11:04.0 9.741 9.612   6.0       94.3 19.8         14.49     141.9
2022-08-07 04:00:00.000 3:34:52.10 -36:11:15.0  9.74 9.612   6.0       94.3 19.8         14.49     141.9
2022-08-07 05:00:00.000 3:34:52.80 -36:11:27.0  9.74 9.611   6.0       94.3 19.8         14.48     142.0
2022-08-07 06:00:00.000 3:34:53.50 -36:11:38.0  9.74 9.611   6.0       94.3 19.8         14.48     142.0
2022-08-07 07:00:00.000 3:34:54.30 -36:11:49.0  9.74  9.61   6.0       94.4 19.8         14.48     142.0
...

@github-actions
Copy link

Thank you for your contribution to sbpy, an Astropy affiliated package! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the sbpy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label.
  • Is a milestone added?

@mkelley
Copy link
Member Author

mkelley commented Mar 25, 2025

Since this is a bug fix on unreleased code, I don't think a change log entry is needed.

@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.60%. Comparing base (f716f24) to head (31b2d57).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   84.60%   84.60%           
=======================================
  Files          92       92           
  Lines        8425     8425           
=======================================
  Hits         7128     7128           
  Misses       1297     1297           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkelley mkelley requested a review from hhsieh00 March 25, 2025 15:47
@mkelley mkelley added this to the v0.6 milestone Mar 25, 2025
Copy link
Collaborator

@hhsieh00 hhsieh00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mkelley mkelley merged commit dac9a95 into NASA-Planetary-Science:main Aug 29, 2025
10 checks passed
@mkelley mkelley deleted the ephem-cli-unit-fix-2025.03 branch August 29, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants