Skip to content

Use title as description when description is empty or NaN#50

Merged
nutjob4life merged 2 commits intomainfrom
feature/pds-scheduler-themes
Feb 6, 2026
Merged

Use title as description when description is empty or NaN#50
nutjob4life merged 2 commits intomainfrom
feature/pds-scheduler-themes

Conversation

@jordanpadams
Copy link
Member

🗒️ Summary

When the CSV description field is empty, pandas stores NaN which was being converted to the string "nan" in the issue body. Now falls back to using the title as the description in these cases.

⚙️ Test Data and/or Report

See tox output in actions

♻️ Related Issues

When the CSV description field is empty, pandas stores NaN which
was being converted to the string "nan" in the issue body. Now
falls back to using the title as the description in these cases.
@jordanpadams jordanpadams requested a review from a team as a code owner February 3, 2026 16:00
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code delta: ✓
Tox run: 😮
Approval: ✅
Details: this delta looks great, and I see that the GitHub checks ran to green, but locally I'm getting test failures:

E           AssertionError: expected call not found.
E           Expected: check_issue_exists('NASA-PDS/test-repo', 'B17 Release Planning')
E             Actual: check_issue_exists('NASA-PDS/test-repo', 'Release Planning')

Odd, innit? Anyway, approved.

@jordanpadams
Copy link
Member Author

@nutjob4life hmm. interesting. I am going to merge the other PR first once it is approved, and then rebase this branch and see if things get cleaned up

@nutjob4life
Copy link
Member

@jordanpadams ahhh, okay, interesting error. Got the same thing. Rebasing ought to do something—unless GitHub itself is having issues again 😬

@nutjob4life nutjob4life merged commit 9a16794 into main Feb 6, 2026
5 checks passed
@nutjob4life nutjob4life deleted the feature/pds-scheduler-themes branch February 6, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants