Skip to content

Conversation

eddiesarevalo
Copy link
Member

-Upgraded the api calls from version 0.1 to 0.2.
-Changed lidvid references to identifier.

Fixes #85

-Upgraded the api calls from version 0.1 to 0.2.
-Changed lidvid references to identifier.
@eddiesarevalo eddiesarevalo added this to the 13.Abebe.Bikila milestone Sep 13, 2021
@eddiesarevalo eddiesarevalo requested a review from a team as a code owner September 13, 2021 23:38
if (identifier.startsWith('10.')) {
endpoint += '?doi=' + encodeURIComponent(identifier);
} else {
let searchIdentifier = identifier.replace(/\//g, '-') + '*';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@collinss-jpl collinss-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, hope it wasn't too difficult to transition to 🙇

@eddiesarevalo eddiesarevalo marked this pull request as draft September 14, 2021 18:56
@eddiesarevalo
Copy link
Member Author

Breaking changes have occurred since the update to the test server. Will commit more fixes before attempting another pull request.

-Updated the UAT keyword auto complete.
-Changed the save draft upload from xml to json.
@eddiesarevalo eddiesarevalo marked this pull request as ready for review September 28, 2021 04:54
-Changed identifier to ids for searching by wildcard.
Copy link
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eddiesarevalo , I will merge the pull request, that works. I've created some bugs aside, we'll see there priority with @jordanpadams

@tloubrieu-jpl tloubrieu-jpl merged commit e907b5a into main Oct 6, 2021
@eddiesarevalo eddiesarevalo deleted the upgrade-to-api-2.0-#85 branch October 11, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOI API v0.2 Compatibility
3 participants