Cookie consent render logic #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
force-pushed
the
cookie-consent-render-logic
branch
from
98624b4
to
7061657
Compare
snmln
reviewed
Nov 4, 2024
| @@ -56,6 +56,8 @@ function LayoutRoot(props: { children?: ReactNode }) { | |||
| const { children } = props; | |||
| const [sessionStart, setSesstionStart] = useState<string | undefined>(); | |||
| const sessionItem = window.sessionStorage.getItem(SESSION_KEY); | |||
| const { pathname } = useLocation(); | |||
There was a problem hiding this comment.
Im a fan of using useLocation but want to double check that this isn't going to cause a problem when implemented in NEXT.js?
There was a problem hiding this comment.
yes, thanks for checking. We are not going to export layout root for library. This is where things that are unique to instances should happen. (ex. routing for Next is not using react-router-dom, but Single Page Application like our current instances will use react-router-dom.)
snmln
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes infinite rerendering issue (it was from the parsing error of cookie value - so I added a unit test to make sure this works. - I used the solution from this post, feel free to edit if you see any improvement https://stackoverflow.com/questions/5142337/read-a-javascript-cookie-by-name) - also feel free to edit the test, I mainly put it for my dev purpose.
I removed currenwindowurl logic, replaced it with pathname passed from the layout root. I started making this change and then realized that this is not the cause of infinite rendering problem, but I think it is probably safer to depend on the pathname change than location.href since href can include so many things like query parameters?