239 invalid use of ari text prefix for binary form of values #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 8, 2025 17:10
BrianSipos
reviewed
Oct 13, 2025
Collaborator
BrianSipos
left a comment
BrianSipos
left a comment
There was a problem hiding this comment.
I think these direct changes are fine. Have some suggestions about TODO items.
It appears that the "ari:0x..." prefix is in the frontend itself and not the transcoder or other components. Is that true? I haven't exercised this with a browser frontend. Perhaps @DavidEdell can confirm this in a browser (the build table will just have all CBOR forms as "0x..." without the "ari:" prefix.
added 7 commits
October 14, 2025 09:53
This reverts commit a082db1.
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
d-linko
deleted the
239-invalid-use-of-ari-text-prefix-for-binary-form-of-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.