Skip to content

removed SSL config not used by ANMS #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
d-linko merged 2 commits into from
Aug 29, 2025
Merged

removed SSL config not used by ANMS #221

d-linko merged 2 commits into from
Aug 29, 2025

Conversation

@d-linko
Copy link
Contributor

@d-linko d-linko commented Aug 27, 2025

No description provided.

@d-linko d-linko requested a review from a team as a code owner August 27, 2025 17:58
@d-linko d-linko linked an issue Aug 27, 2025 that may be closed by this pull request
Remove dead code to resolve SonarQube security issues #213
Closed
3 tasks
@github-project-automation github-project-automation bot moved this to Todo in ANMS Aug 27, 2025
BrianSipos
BrianSipos reviewed Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@BrianSipos BrianSipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are some of these files not even used by ANMS or during test? It could be a good cleanup activity to remove.

@BrianSipos
Copy link
Collaborator

BrianSipos commented Aug 28, 2025

These CI jobs have also been failing on main since about three weeks
https://github.com/NASA-AMMOS/anms/actions/runs/16784584801/job/47531746965

And the podman failure seems to be related to the workaround comment in #132

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 28, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@d-linko
Copy link
Contributor Author

d-linko commented Aug 28, 2025

Are some of these files not even used by ANMS or during test? It could be a good cleanup activity to remove.

removed anms-core/test since it looks integration_test took over testing asgi/server isnt used in production but is used by the run_dev script for deploying anms-core during local development

@d-linko d-linko requested a review from BrianSipos August 29, 2025 17:12
@d-linko d-linko merged commit 604991b into main Aug 29, 2025
9 of 12 checks passed
@d-linko d-linko deleted the 213-remove-dead-code-to-resolve-sonarqube-security-issues branch August 29, 2025 19:28
@github-project-automation github-project-automation bot moved this from Todo to Done in ANMS Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrianSipos BrianSipos Awaiting requested review from BrianSipos

Assignees

No one assigned

Labels

None yet

Projects

ANMS
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove dead code to resolve SonarQube security issues

2 participants

@d-linko @BrianSipos