Removal of NGINX #189
Merged
Removal of NGINX #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianSipos
requested changes
May 22, 2025
Collaborator
BrianSipos
left a comment
BrianSipos
left a comment
There was a problem hiding this comment.
Some specific suggestions or questions in-line. I will defer to @d-linko to try running this branch and seeing that the normal browser UI looks okay, specifically the grafana dashboard.
d-linko
approved these changes
May 22, 2025
Contributor
d-linko
left a comment
d-linko
left a comment
There was a problem hiding this comment.
deployed changes locally and UI working as intended. One change was to remove NGINX as a service the status page was tracking
DavidEdell
commented
May 22, 2025
BrianSipos
approved these changes
May 29, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #176 by moving behavior directly into the authnz container. This utilizes the existing PROXY_URLS option for the cam-gateway container, and duplicates that functionality for the basic password authentication option.
In the future, we may consider farther consolidating these definitions with that used by the system_status.py into a single JSON file that can be copied to all relevant containers. At present, if a hostname or mapping is updated both of these locations and likely the .env file would all need to be updated.
The 2 auth options have also been consolidated into a single "auth" folder and "authnz-emu" renamed for clarity.
NOTE: AMMOS deployment may need to be updated to reflect the 'PROXY_URLS' env variable now set in docker-compose.yml for both auth options.
NOTE: This branch was created on top of the 'experimental' branch. It may (pending review) be necessary to merge this into experimental first prior to resolving any conflicts to merge back into main.