Allow the legend tool to be right justified on the screen #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariqksoliman
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Nice!
A couple of things:
- Include an example Raw Variables in "descriptionFull" in
src/essence/Tools/Legend/config.json- See other tool config.jsons for examples. This makes it so that in the Tools tab of the /configure page, you can click on the tool's info icon and see it as an example
- Not as critical either but the right hand side of the screen is a bit tricky: The map Zoom In and Out are option (see /configure look tab). And when Zoom In and Out are enabled, the right side Legend covers the websockets refresh/reload page icon. It's a bit trickier still because the existing right-side icons are often fixed to the panel (map, viewer, globe) and not the screen. Again it's minor, so feel free to merge. Likely all the right-side icons need to be drawn more intelligently.
|
Added the example in descriptionFull. I'm going to leave the right hand side icon updates for another day. I'm not familiar with how to enable the websockets icon and it does get tricky with the globe and viewer on. |
tariqksoliman
added a commit
that referenced
this pull request
Sep 6, 2023
* Make sure to remove time tab in time disabled * IFrame examples * #279 Time Improvements (#280) * Configure global start end time, Partial local vector time filter * #279 Time Improvements * InfoTool checks for links in metadata and renders anchor tags * Fix environment variable in sample.env for enabling websockets (#281) * Fix environment variable in sample.env for enabling websockets * Update docs * Bug Fix: Don't drawing uncertainty ellipse if either axis is 0 * ts-282 Composite Time Tiles, Time Tiles with range (#283) * Update Time Tile path structure * #285 init-db (#286) * #290 Upgrade config page jquery, fix i closing tag (#291) * #292 Controlled Time Layers only make initial query, refactored to remove a conflicting setTimeout (#293) * Fix crash when Time is completely disabled * #296 Fix WMS url query (#297) * #298 TimeUI Pan and Zoom and Improvements (#299) * #298 Early TimeUI Pan Zoom * #298 Pan, zoom, steps, modes, mostly done * TimeUI Improvements and verifications * #298 Fix Point Play bug * #298 Final Touchups * Make marker bearings projection-aware * Update Docs, Add redundant stopGuests check * Fix Invalid Date when using deep linked timestamps, improve mmgisAPI docs * Fix typo * #294 SameSite None env and login improvements (#302) * #294 SameSite First pass * #294 Fix session and use postgres as session store * Use a default session db port * #294 Regenerate session on login failure too * Add feature to reconnect WebSocket from client to server (#295) * Add materialize-css package * Update WebSocket on client side * Double reconnect attempt interval every time websocket reconnection attempt fails * Update package-lock.json * Move toast to be ~5 pixels from the right side * Only show 'Successfully Connected' toast if websocket connection has previously failed * Fix toast display time * #304 Fix bug in latest too * Layer UUIDs (#308) * #306 UUIDs part 1 * #306 Layer UUIDs UI touchups, still missing Config API * #306 Layer UUIDs for Config API * #309 Controlled Raster for initial query only (#311) * Fix function call order bug in addNewLayer function (#310) * Account for non-uuid deep link names * Fix toggleLayer bug (#260) * Fix Node 18+ build (#312) * #317 Fix time vectors not applying correctly (#319) * Fix bug where initially on annotations features have no click events * Add function to overwrite elements displayed in LegendTool (#320) * Add function to overwrite elements displayed in LegendTool * Add more checks to overwriteLegends function * Add overwriteLegends to mmgisAPI * #322 Add ROOT_PATH, Deprecate PUBLIC_URL (#323) * #322 ROOT_PATH, doesn't work fully for /configure yet * #322 ROOT_PATH for runtime subpaths * #322 Remove PUBLIC_URL and fix ROOT_PATH css * Update README.md * Update README.md * #324 Configurable Context Menu Actions (#325) * #324 Coordinates Config Tab Raw Variables * #324 Configurable context menu actions * Add docker build workflow * Make sure user input UUIDs through REST API are unique (#326) * Make sure user input UUIDs through REST API are unique * Fix overwriting existing UUID issue * #327 Assorted UI Improvements (#328) * #313 Expose as much as possible to the mmgisAPI (#330) * #313 Add Formulae_ * #313 More F_ docs * #313 Finish up F_ docs * #313 mmgisAPI addLayer and removeLayer * #313 Add logged_in endpoint and early Backend API docs * #331 Websocket aware configure page (#332) * #331 Websocket aware configure * Remove console.log * Update addLayer and removeLayer endpoints in REST API (#337) * Working on updating REST API * Do not update config if there are duplicate or bad UUIDs * Update docs * #303 Photosphere Targets and Target Pairing (#340) * #303 Pairings attachments, photosphere targets not working yet * #303 AzEl computed markers in Photosphere, deleted old docs * Add back in swagger docs * #303 Use originOFfset * Refactor with the uuid upgrade, Update docs * #341 Export working config, disable override (#342) * Add xml2js and proj4 packages. (#343) * add xml2js * Fix DrawTool Upload Loading style * Draw Edit properties * #335 Feature Request: GetMissions (#345) * #335 /configure/mission full param * #335 touchup docs * Fix typo * #346 Deep Link additional encodeURI * Fix missing uuids from configure * WMS TILESIZE param, features without uncertainty properties won't draw in Map, github link of docs page * Fix clearOnMapClick function for layers with no fill (#348) * Fix angleUnit on image attachment * Optional Info button for projects that need a link to project info #350 * Support existing az el properties for pairing attachments * Fix bug in Photosphere where points with matching names get stuck * Add dontFloor to mod function * Updates to info and help buttons - Hide info and help icons if a url is not configured - Default the info button to be off in the configuration - Change to info icon with a circle * #352 [New Feature]: DrawTool - Feature Property Templates (#353) * #352 Templating 1 * #352 Templating 2 * #352 Templating 3 * #352 Update Modal for templating * #352 Migrate DrawTool Templating * #352 Templating touchups * #354 Add MAIN_MISSION ENV (#355) * Do not append time parameters to wmts tile layers * Fix configure layer cloning * Remove typo ; in MAIN_MISSION env * Remove outdated firefox-specific css fix * Add blob to default-src csp * #356 DrawTool Templating - Incrementer field (#357) * #358 - DrawTool - Grouping editing should only update changed template fields (#359) * #360 Expose all endpoints to longtermtokens (#362) * #363 Support file_owner in webhook body. Include body for onFileDelete (#364) * Fix layer uuids showing up in bottom-right coords * Expose ToolController_ * #366 Don't copy uuid on layer clone (#367) * #369 Refresh vector layers, also some WEBSOCKET_ROOT_PATH (#370) * #368 Fix Websocket usage with ROOT_PATH (#373) * #369 Refresh vector layers, also some WEBSOCKET_ROOT_PATH (#370) (#371) * #368 Websockets use ROOT_PATH * #368 Fix configure websocket * Fix bad Configure/websockets json writing * Fix time memory leak from improper cleanup of tooltips and slider * chore(config): Inline import from same namespace (#375) * #378 LegendTool as Popup (#379) * #378 Separate legend tool * #378 Legend formatting, reacts to layer toggles * #380 DrawTool - Fix error saving templateless features (#381) * Reset stroke styles too * fix(imports): destructure modules (#384) * chore(naming): use standardized name (#385) * Add event listener for toggleSeparatedTool in MMGIS API (#388) * Prioritize Map splitscreen size when resizing * #372 calls to updateVectorLayer and appendLineString cause selected feature to be deselected when using info tool (#389) * #372 Reselect feature on updateVectorLayer and appendLineString * #372 Non-async updateVectorLayer, fix Pairings update * Remove description transition * Persist active feature on appendLineString * #390 InfoTool - Clicks Intersect Polygons (#391) * #387 DrawTool - Group Editing (#392) * #387 DrawTool - Group edit files Part 1 * #387 DrawTool - Group edit files Part 2 * DrawTool / Group Editing - Let other users save changes to features * Added an option to the LegendTool to automatically display on start * LegendTool needs to have hasVars set to true for the last commit * Added max-width to legend to prevent long text from filling screen * Added a .nvmrc file with node version * Added ellipsis and title for overflow legend text * #386 Local Login Issue (#396) * #386 Add setLoginToken to mmgisAPI * #386 Fix variable path * #386 SKIP_CLIENT_INITIAL_LOGIN env + mmgisAPI.initialLogin * #383 Support raster option on gdal2tiles_3.5.2/gdal2customtiles (#397) * #383 gdal2tiles_3.5.2_v2 for raster support * #383 Cleanup gdal2tiles scripts and improve documentation * #383 gdal2customtiles extentworld working, overview tiles not working * #383 Fix gdal2customtiles rasters with different pixel scales * gdal2customtiles - fix width calc, still slight offset * gdal2customtiles raster - fix rounding issues * Fix mmgisAPI featuresContained when a failed to load layer = null * #399 Crashes if Layers are valid JSON but not valid GeoJSON (#400) * #399 Add geojson validater to map * #399 allow overloaded coordinates in geojson for extended geojson * #401 Extend CSSO timeout check to main client (#402) * #401 Main site timeout notification part 1 * #401 Main site timeout notification part 2 * #401 Main site timeout notification - warn at 20 min * #403 rightClickMenuActions - Polygons and WKT (#404) * #403 - Bugfixes and rightclick finds features * #403 ContextMenu, Actions on features, WKT link populate * #405 DrawTool - Template - Incrementer - Move to backend (#406) * Mini fix to allow [] as empty geojson layer data * Fix DrawTool Incrementer self collision bug * Convert layer data [<FeatureCollection>] to geojson * #407 Click intersects on Query and Draw layers (#408) * #407 Include Query layers in click intersections * #407 Support intersects on DrawTool layers too * Allow the legend tool to be right justified on the screen * #409 Added example config in description for LegendTool * #410 Draw Tool - Time Integration (#411) * ts-410 DrawTool - Temporal part 1 * #410 DrawlTool - Temporal Integration * #410 Clearer DrawTool Template Date Start/End Icons * #412 Add Configuration Option to set TimeUI Extent (#413) * #414 IdentifierTool works again with human layer names (#415) * #422 Removed event blocking popup functions (#423) * Bump to 2.9.0 --------- Co-authored-by: ac-61 <ac-61@users.noreply.github.com> Co-authored-by: Joe Roberts <joe.t.roberts@jpl.nasa.gov> Co-authored-by: Even Stensberg <evenstensberg@gmail.com>
tariqksoliman
added a commit
that referenced
this pull request
Oct 23, 2023
* MMGIS 2.6.0 (#160) * Added function to set initial layer times based on current time * Remove debug print out (#126) * #127 DrawTool - enable panning around without dropping points while d… (#128) * #127 DrawTool - enable panning around without dropping points while drawing * DrawTool - make active layer deselectable * DrawTool - Fix uploaded file edit panel * #129 BottomBar UI Visibility Modal (#130) * Fix PUBLIC_URL configure urls (#131) * env comment on DB_HOST in docker * Fix controlled layer returning null * Sublayers on Controlled Layers * #134 - Any Projection Image Marker Attachments (#137) * #139 Control Raster Filters in LithoSphere (#140) * Update litho to css friendly filter effects * #138 Projection agnostic Uncertain Ellipses, touch ups (#141) * Minor colorramp dropdown fix * leaflet-imagetransfrom map check * Dockerfile node:16 (#145) * Update README.md Node 10.10 -> Node 14.9.0 * Implement webhooks feature (#146) * First implementation of webhooks * Remove webhooktoken field * Reorganize files and functions * Clean up webhook cards * Add routes for testing webhooks when using development environment * Fix Config subpage scrollbar issue * Fix delete button Co-authored-by: Tariq Soliman <Tariq.K.Soliman@jpl.nasa.gov> * Added docs for how to use remote virtual layers via GDAL - Also updated Measure Tool to support remote DEMs * A bit more info on gdalwmscache directory in docs * Remote_Virtual_Layer typo fixes * Curtain Support (#152) * Curtain part 2 * rgrams styles * Touch ups * Use litho 1.3.0 * #151 Support 3D Uncertainty Ellipses on Point Features (#153) * 3D Uncertainty ellipses * #151 Upgrade lithosphere, more uncertainty ellipse options, docs * Fix minor bugs (#155) * Upgrade litho * Litho 1.3.2 * Litho 1.3.3 * Add LineString functions (#156) * Add function to trim layers containing LineString features * Add appendLineString function and clean up trimLineString function * Remove debug code * Minor fixes * Add args to dockerfile so PUBLIC_URL can be specified at image build time (#157) Co-authored-by: David Lees <david.lees@nasa.gov> * Update the globe when vector layers are modified (#158) * Update the globe when vector layers are modified * Remove extraneous code * Remove extra variable * Fixed vector time updates not actually refreshing when told to reload (#159) * Dropdowns can expand up, draw tests * Bump to 2.6.0 Co-authored-by: Joe Roberts <joe.t.roberts@jpl.nasa.gov> Co-authored-by: ac-61 <ac-61@users.noreply.github.com> Co-authored-by: dsl3000 <dsl3001@gmail.com> Co-authored-by: David Lees <david.lees@nasa.gov> * Description should be updated to match example code (#189) * ci: build docker image and push to GitHub Container Registry (#316) * Update docker-build workflow to trigger on deve branch and releases * #336 Add GitHub Templates (#338) * #399 Crashes if Layers are valid JSON but not valid GeoJSON (#400) * #399 Add geojson validater to map * #399 allow overloaded coordinates in geojson for extended geojson * #401 Extend CSSO timeout check to main client (#402) * #401 Main site timeout notification part 1 * #401 Main site timeout notification part 2 * #401 Main site timeout notification - warn at 20 min * #403 rightClickMenuActions - Polygons and WKT (#404) * #403 - Bugfixes and rightclick finds features * #403 ContextMenu, Actions on features, WKT link populate * #405 DrawTool - Template - Incrementer - Move to backend (#406) * Mini fix to allow [] as empty geojson layer data * Fix DrawTool Incrementer self collision bug * Convert layer data [<FeatureCollection>] to geojson * #407 Click intersects on Query and Draw layers (#408) * #407 Include Query layers in click intersections * #407 Support intersects on DrawTool layers too * Allow the legend tool to be right justified on the screen * #409 Added example config in description for LegendTool * #410 Draw Tool - Time Integration (#411) * ts-410 DrawTool - Temporal part 1 * #410 DrawlTool - Temporal Integration * #410 Clearer DrawTool Template Date Start/End Icons * #412 Add Configuration Option to set TimeUI Extent (#413) * #414 IdentifierTool works again with human layer names (#415) * #422 Removed event blocking popup functions (#423) * Bump to 2.9.0 * #425 Description Item fixes (#426) * #425 Description Item fixes * Remove outdated comment * Remove odd duplicate triggerWebhookds * Fix draw upload webhook not populating geojson field * Remove extra log * Fix DrawTool deleting tag closing modal bug * DrawTool - Remove timetoggle when tool closes * DrawTool - Deselect file when turning off * #427 Expandable Tools (#428) * #427 Allow DrawTool names to expand too * #429 Hotkeys (#430) * #239 Hotkeys 1 * #429 DrawTool toggle last file hotkey * shortcutSuffix and raw variables for tile layers * Update Dependencies (#431) * #365 Separate out dev deps in package.json * Closer but webapck is broken * Dev server works - build still broken * Fix build * Update Expressjs * docker build workflow - add no-cache param * Update ModuleScopePlugin * #432 Image Overlay Fixes (#433) * #435 DrawTool - Reorder Template fields (#436) * #437 Add CONTRIBUTING.md (#438) * Update README.md * #439 DrawTool - Add Advanced Search and Filter UI to Shapes Tab (#440) * #439 DrawTool Shape Tab Filter * #439 DrawTool - Features Tab filter 2 * Support booleans in LocalFilterer --------- Co-authored-by: fcalef <49040273+fcalef@users.noreply.github.com> Co-authored-by: Joe Roberts <joe.t.roberts@jpl.nasa.gov> Co-authored-by: ac-61 <ac-61@users.noreply.github.com> Co-authored-by: dsl3000 <dsl3001@gmail.com> Co-authored-by: David Lees <david.lees@nasa.gov> Co-authored-by: David Tsay <3614296+davetsay@users.noreply.github.com> Co-authored-by: James Montalvo <jamesmontalvo3@gmail.com>
tariqksoliman
added a commit
that referenced
this pull request
Nov 8, 2023
* #398 ShadeTool part 1 * #398 Spice, somewhat working shade tool, needs touchups and verification * #398 Update python-requirement.txt * #398 Improve shade tool 1 * #398 Auto fill dynamic template * #398 Chronos part 1 * #398 Add getKernel helpers * #398 Shade - Chronos integration, test with 2 orbiters, cleanup UI, sources and observers from config * #398 Final touchups, docs, includeSunEarth, bug fixes, utc instead of tdb * #398 configurable height, remove altitude, timeUI start in point mode * #398 Fix bad target lnglat issue and fix altitude units * touchups * Update python-requirements.txt * Update Dockerfile * Update python-requirements.txt * Merge Dev into Feature Branch (#441) * MMGIS 2.6.0 (#160) * Added function to set initial layer times based on current time * Remove debug print out (#126) * #127 DrawTool - enable panning around without dropping points while d… (#128) * #127 DrawTool - enable panning around without dropping points while drawing * DrawTool - make active layer deselectable * DrawTool - Fix uploaded file edit panel * #129 BottomBar UI Visibility Modal (#130) * Fix PUBLIC_URL configure urls (#131) * env comment on DB_HOST in docker * Fix controlled layer returning null * Sublayers on Controlled Layers * #134 - Any Projection Image Marker Attachments (#137) * #139 Control Raster Filters in LithoSphere (#140) * Update litho to css friendly filter effects * #138 Projection agnostic Uncertain Ellipses, touch ups (#141) * Minor colorramp dropdown fix * leaflet-imagetransfrom map check * Dockerfile node:16 (#145) * Update README.md Node 10.10 -> Node 14.9.0 * Implement webhooks feature (#146) * First implementation of webhooks * Remove webhooktoken field * Reorganize files and functions * Clean up webhook cards * Add routes for testing webhooks when using development environment * Fix Config subpage scrollbar issue * Fix delete button Co-authored-by: Tariq Soliman <Tariq.K.Soliman@jpl.nasa.gov> * Added docs for how to use remote virtual layers via GDAL - Also updated Measure Tool to support remote DEMs * A bit more info on gdalwmscache directory in docs * Remote_Virtual_Layer typo fixes * Curtain Support (#152) * Curtain part 2 * rgrams styles * Touch ups * Use litho 1.3.0 * #151 Support 3D Uncertainty Ellipses on Point Features (#153) * 3D Uncertainty ellipses * #151 Upgrade lithosphere, more uncertainty ellipse options, docs * Fix minor bugs (#155) * Upgrade litho * Litho 1.3.2 * Litho 1.3.3 * Add LineString functions (#156) * Add function to trim layers containing LineString features * Add appendLineString function and clean up trimLineString function * Remove debug code * Minor fixes * Add args to dockerfile so PUBLIC_URL can be specified at image build time (#157) Co-authored-by: David Lees <david.lees@nasa.gov> * Update the globe when vector layers are modified (#158) * Update the globe when vector layers are modified * Remove extraneous code * Remove extra variable * Fixed vector time updates not actually refreshing when told to reload (#159) * Dropdowns can expand up, draw tests * Bump to 2.6.0 Co-authored-by: Joe Roberts <joe.t.roberts@jpl.nasa.gov> Co-authored-by: ac-61 <ac-61@users.noreply.github.com> Co-authored-by: dsl3000 <dsl3001@gmail.com> Co-authored-by: David Lees <david.lees@nasa.gov> * Description should be updated to match example code (#189) * ci: build docker image and push to GitHub Container Registry (#316) * Update docker-build workflow to trigger on deve branch and releases * #336 Add GitHub Templates (#338) * #399 Crashes if Layers are valid JSON but not valid GeoJSON (#400) * #399 Add geojson validater to map * #399 allow overloaded coordinates in geojson for extended geojson * #401 Extend CSSO timeout check to main client (#402) * #401 Main site timeout notification part 1 * #401 Main site timeout notification part 2 * #401 Main site timeout notification - warn at 20 min * #403 rightClickMenuActions - Polygons and WKT (#404) * #403 - Bugfixes and rightclick finds features * #403 ContextMenu, Actions on features, WKT link populate * #405 DrawTool - Template - Incrementer - Move to backend (#406) * Mini fix to allow [] as empty geojson layer data * Fix DrawTool Incrementer self collision bug * Convert layer data [<FeatureCollection>] to geojson * #407 Click intersects on Query and Draw layers (#408) * #407 Include Query layers in click intersections * #407 Support intersects on DrawTool layers too * Allow the legend tool to be right justified on the screen * #409 Added example config in description for LegendTool * #410 Draw Tool - Time Integration (#411) * ts-410 DrawTool - Temporal part 1 * #410 DrawlTool - Temporal Integration * #410 Clearer DrawTool Template Date Start/End Icons * #412 Add Configuration Option to set TimeUI Extent (#413) * #414 IdentifierTool works again with human layer names (#415) * #422 Removed event blocking popup functions (#423) * Bump to 2.9.0 * #425 Description Item fixes (#426) * #425 Description Item fixes * Remove outdated comment * Remove odd duplicate triggerWebhookds * Fix draw upload webhook not populating geojson field * Remove extra log * Fix DrawTool deleting tag closing modal bug * DrawTool - Remove timetoggle when tool closes * DrawTool - Deselect file when turning off * #427 Expandable Tools (#428) * #427 Allow DrawTool names to expand too * #429 Hotkeys (#430) * #239 Hotkeys 1 * #429 DrawTool toggle last file hotkey * shortcutSuffix and raw variables for tile layers * Update Dependencies (#431) * #365 Separate out dev deps in package.json * Closer but webapck is broken * Dev server works - build still broken * Fix build * Update Expressjs * docker build workflow - add no-cache param * Update ModuleScopePlugin * #432 Image Overlay Fixes (#433) * #435 DrawTool - Reorder Template fields (#436) * #437 Add CONTRIBUTING.md (#438) * Update README.md * #439 DrawTool - Add Advanced Search and Filter UI to Shapes Tab (#440) * #439 DrawTool Shape Tab Filter * #439 DrawTool - Features Tab filter 2 * Support booleans in LocalFilterer --------- Co-authored-by: fcalef <49040273+fcalef@users.noreply.github.com> Co-authored-by: Joe Roberts <joe.t.roberts@jpl.nasa.gov> Co-authored-by: ac-61 <ac-61@users.noreply.github.com> Co-authored-by: dsl3000 <dsl3001@gmail.com> Co-authored-by: David Lees <david.lees@nasa.gov> Co-authored-by: David Tsay <3614296+davetsay@users.noreply.github.com> Co-authored-by: James Montalvo <jamesmontalvo3@gmail.com> --------- Co-authored-by: fcalef <49040273+fcalef@users.noreply.github.com> Co-authored-by: Joe Roberts <joe.t.roberts@jpl.nasa.gov> Co-authored-by: ac-61 <ac-61@users.noreply.github.com> Co-authored-by: dsl3000 <dsl3001@gmail.com> Co-authored-by: David Lees <david.lees@nasa.gov> Co-authored-by: David Tsay <3614296+davetsay@users.noreply.github.com> Co-authored-by: James Montalvo <jamesmontalvo3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Proposed Changes
Issues
Testing