Skip to content
This repository was archived by the owner on Mar 13, 2023. It is now read-only.

feat: Improve type hinting of EventMixinTemplate #520

Merged
merged 1 commit into from
Jun 10, 2022
Merged

feat: Improve type hinting of EventMixinTemplate #520

merged 1 commit into from
Jun 10, 2022

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

This PR informs type hinting that EventMixinTemplate has all the same attributes as the Client

Changes

  • Create template.pyi and lie about the parent class

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added the Improvement Something that is already implemented but can be done better label Jun 8, 2022
@LordOfPolls LordOfPolls merged commit 6528231 into dev Jun 10, 2022
@LordOfPolls LordOfPolls deleted the event_template_typing branch June 18, 2022 19:57
@AstreaTSS AstreaTSS mentioned this pull request Jan 3, 2025
Merged
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@silasary silasary silasary approved these changes

@Kigstn Kigstn Kigstn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Improvement Something that is already implemented but can be done better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LordOfPolls @silasary @Kigstn