Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix determination of total members #43

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Fix determination of total members #43

merged 1 commit into from
Nov 29, 2022

Conversation

Radonirinaunimi
Copy link
Member

Fix the determination of the total members in the checks caused by API changes.

Copy link
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only place where the vp to c++ interface is used?

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #43 (ca11263) into master (fbb21c6) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #43   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          16      15    -1     
  Lines        1375    1374    -1     
======================================
+ Misses       1375    1374    -1     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pycompressor/compressing.py 0.00% <0.00%> (ø)
src/pycompressor/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbb21c6...ca11263. Read the comment docs.

@Radonirinaunimi
Copy link
Member Author

Is this the only place where the vp to c++ interface is used?

Yes, this is the only place.

@Radonirinaunimi Radonirinaunimi merged commit 06bb0b6 into master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'LHAPDFSet' object has no attribute 'GetMembers'
2 participants