Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immersion conflict with certain dialogs #16

Closed
Chamlotte opened this issue Nov 27, 2022 · 8 comments
Closed

Immersion conflict with certain dialogs #16

Chamlotte opened this issue Nov 27, 2022 · 8 comments
Labels
bug Something isn't working

Comments

@Chamlotte
Copy link

With both this and Immersion, some dialogs leave what i would just call a ghost dialog box that dialogkey tries to interact with.

The easiest test was just a transmogrifier. Talk to them, hit space(or 1, to select that dialog option), and now every time you hit space DK is trying to hit a dialog box that isn't there anymore, even after leaving the transmog. Opening up another dialog clears this issue.

No lua error is produced.

https://i.imgur.com/uaLCDCS.mp4

@FuriousProgrammer
Copy link
Collaborator

Now that is strange. It looks like it's trying to click a button on a Gossip panel, which means that the Gossip panel :IsVisible() is returning true, despite it clearly not being Visible.

I'll look into what Immersion is doing to cause this and figure out a workaround.

I can't actually test anything for a couple hours, so if you see this quicklike please let me know if pressing Escape (or whatever your keybind for closing menus is if you've changed it!) disabled the "ghost" Gossip panel.

@FuriousProgrammer FuriousProgrammer added the bug Something isn't working label Nov 27, 2022
@Chamlotte
Copy link
Author

Chamlotte commented Nov 28, 2022

Trying to hit escape just gives the normal escape menu, and mashing space even then looks like it's trying to hit a dialog option.

Edit: This seems to happen with any dialog that opens directly to another window, the anima screen caused it as well.

@FuriousProgrammer
Copy link
Collaborator

Anima deposit, you mean?

I'll take a look once I get home if Immersion is causing this to occur or if that's part of DialogKey itself.

In any case, Immersion has its own options for keybinds for quest and gossip stuff, I presume you personally just want DialogKey for the StaticPopup stuff (e.g. release spirit, accept rez, group invite etc.)?

I ask because it's simpler to disable DialogKey stuff for the non-popups than to insert a workaround for specifically what Immersion does that is breaking DialogKey.

@Chamlotte
Copy link
Author

Oh, yeah, i use it mainly for StaticPopup stuff, since immersion already hooks into the regular quest/npc windows.

@N0ich
Copy link
Owner

N0ich commented Nov 28, 2022

Hello,
Are you sure you are using the latest version of dialogkey? Im trying to reproduce this with the latest version and I can't, on neither the transmogrifier nor the anima collector. I remember fixing something like that at some point so i'd assume you don't use the latest version.
Otherwise it's a bug between Immersion and DK, in which case you should probably adapt the addon to just interact with Popups

@Chamlotte
Copy link
Author

Chamlotte commented Nov 28, 2022

I was using 1.3.5b, which is what i found over on curse, but now i see a 1.4.0b to update to. Sure didn't see it yesterday!

Updated and tested it out. Still happens. Note that the cause seems to be related to closing the gossip to open another window. Stable master, any dialog that goes into a shop (but not going into a shop directly) also causes it.

Also, how would i adapt it to just work with popups?

@smbody-mipt
Copy link

Also appears to still be happening even if gossip option is disabled in DK, even after interface reload - maybe it hooks by default regardless of the option and still causes the issue.

@FuriousProgrammer
Copy link
Collaborator

Testing this just now with the most recent version of Immersion with their default settings (and a minor fix to make sure the gossip ordering is always correct in DK), and I cannot reproduce this behavior.

I'll add a chat message saying that Immersion is known to conflict with DialogKey, but as best I can figure this issue is resolved by some change made recently to Immersion itself.

@FuriousProgrammer FuriousProgrammer closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2022
FuriousProgrammer added a commit that referenced this issue Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants