Skip to content

sui_v1.32.0_1723750583_ci

sui_v1.32.0_1723750583_ci: [move-ide] Fixed a bug preventing pkg build from VSCode (#19003)
@awelc awelc tagged this 15 Aug 17:44 
## Description 

This PR fixes a problem recently reported in
https://github.com/MystenLabs/sui/issues/18749 and
https://github.com/MystenLabs/sui/issues/18983. When creating `git`
commands using `Command::new(...).status()` standard input inherited
from VSCode was somehow causing the child process to hang, even though
the commands created did not in fact require any input. This only
happened on Windows and while admittedly I do not understand the root
cause (perhaps one of the reviewers can help), it does fix the problem.

## Test plan 

All existing tests must pass. Additionally, manually verified that the
build no longer hangs on Windows.
Assets 2
Loading