[ts-sdk] tx block rename #9941
Merged
[ts-sdk] tx block rename #9941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Mysten
requested review from
randall-Mysten and
ronny-mysten
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
|
Jordan-Mysten
force-pushed
the
jordan--SDK_rename_methods
branch
from
e508573 to
069cfd2
Compare
Jordan-Mysten
force-pushed
the
jordan--SDK_rename_methods
branch
from
069cfd2 to
ef52e9c
Compare
Jordan-Mysten
force-pushed
the
jordan--SDK_rename_methods
branch
from
ef52e9c to
ca08511
Compare
sblackshear
approved these changes
Mar 27, 2023
666lcz
reviewed
Mar 27, 2023
| @@ -64,7 +64,7 @@ function TransferCoinPage() { | |||
| }); | |||
|
|
|||
| return signer.signAndExecuteTransaction({ | |||
There was a problem hiding this comment.
should we also rename this to signAndExecuteTransactionBlock?
There was a problem hiding this comment.
Yeah happening in this follow-up: #9946
Jordan-Mysten
added a commit
that referenced
this pull request
Mar 27, 2023
## Description This is a follow-up for #9941, renaming provider methods and wallet adapter methods. ## Test Plan Tests should still pass.
666lcz
pushed a commit
that referenced
this pull request
Mar 28, 2023
## Description Updating naming of transaction builder APIs. ## Test Plan Tests should still pass.
666lcz
pushed a commit
that referenced
this pull request
Mar 28, 2023
This is a follow-up for #9941, renaming provider methods and wallet adapter methods. Tests should still pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating naming of transaction builder APIs.
Test Plan
Tests should still pass.