Wrap NW Cert in versioned enum #9878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
mwtian
approved these changes
Mar 27, 2023
narwhal/types/src/primary.rs
Outdated
| let mut ret = self.header.digest() == other.header.digest(); | ||
| match (self, other) { | ||
| (Certificate::V1(data), Certificate::V1(other_data)) => data.eq(other_data), | ||
| _ => false, |
There was a problem hiding this comment.
Just remove the false variant for now? We can add it back in future. One way to avoid missing variant, is to only add match arms for (Certificate::Vi(data), Certificate::Vi(other_data)) and (Certificate::Vi(data), _), and not add match arm for _.
There was a problem hiding this comment.
Actually thats a good point, I will remove all wildcard checks for now and if anyone adds a variant the rust compiler will complain and notify us to update this as well.
+ fix format test
arun-koshy
force-pushed
the
arun/cert-versioning
branch
from
af3bd55 to
af66292
Compare
mwtian
pushed a commit
that referenced
this pull request
Mar 27, 2023
## Test Plan Unit Test & Benchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
Unit Test & Benchmark