[explorer] Rebuild transactions for address and object #9852
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
| const tableData = genTableDataFromTxData(data); | ||
|
|
||
| return ( | ||
| <div data-testid="tx"> |
There was a problem hiding this comment.
is this data-testid needed for an E2E test? if so, a more descriptive name would be nice 😄
| ) | ||
| ); | ||
|
|
||
| return [...results[0].data, ...results[1].data].sort( |
There was a problem hiding this comment.
this might be a pre-mature optimization, but I recently learned about the select option in react-query for doing data transformations which could be nice to use here
There was a problem hiding this comment.
That makes sense when we want to have a view over the data that we're fetching, but in this case this is defining the actual return data (basically simulating a single list). Eventually this will move to a single queryTransaction which will also solve this problem.
Jordan-Mysten
force-pushed
the
jordan--Rebuild_transactions_for_address_/_object
branch
from
4d662d5 to
d82a8a4
Compare
Jordan-Mysten
deleted the
jordan--Rebuild_transactions_for_address_/_object
branch
## Description On object and address pages, the transaction table used a deprecated method and required calling multiGetTransactions to populate. This caused it to fail for big objects / transactions. Rewriting onto native queryTransactions. For now, this has the limitation of not being able to paginate, because we need to interleave two result sets. But once the API is updated to support this filter we can pretty easily change that. ## Test Plan Ran locally.
Description
On object and address pages, the transaction table used a deprecated method and required calling multiGetTransactions to populate. This caused it to fail for big objects / transactions. Rewriting onto native queryTransactions. For now, this has the limitation of not being able to paginate, because we need to interleave two result sets. But once the API is updated to support this filter we can pretty easily change that.
Test Plan
Ran locally.