Use bytes representation for Certificate::aggregate_signature #9697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
6 tasks
jonas-lj
requested review from
benr-ml
and removed request for
kchalkias and
joyqvq
jonas-lj
commented
Mar 22, 2023
| @@ -605,7 +606,7 @@ impl Certificate { | |||
|
|
|||
| Ok(Certificate { | |||
| header, | |||
| aggregated_signature, | |||
| aggregated_signature: AggregateSignatureBytes::from(&aggregated_signature), | |||
There was a problem hiding this comment.
It might be overkill for this problem, but we could also use the Cached object solution you proposed, @benr-ml, in order to avoid that signatures are deserialised even if they are created here and not read from disk.
benr-ml
approved these changes
Mar 22, 2023
benr-ml
pushed a commit
that referenced
this pull request
Mar 22, 2023
## Description Profiling has shown that validators spend a significant amount of CPU resources deserialising the `aggregate_signature` field in NW's `Certificate` object when read from disk. This is because signatures by default are stored as compressed points, so deserialisation needs to decompress points which is a non-trivial computation. However, in most cases the signature does not need to be verified, and in these cases the binary representation suffices. This PR replaces the `aggregate_signature` field in NW's `Certificate` object with its `AsBytes` representation, and the signature is only decompressed when the signature actually have to be verified. According to recently produced perf flame graphs, this could save ~2% CPU usage for validators. ## Test Plan Unit tests. ### Type of Change (Check all that apply) - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [X] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [X] necessitate either a data wipe or data migration
danaiballa
pushed a commit
that referenced
this pull request
Mar 23, 2023
## Description Profiling has shown that validators spend a significant amount of CPU resources deserialising the `aggregate_signature` field in NW's `Certificate` object when read from disk. This is because signatures by default are stored as compressed points, so deserialisation needs to decompress points which is a non-trivial computation. However, in most cases the signature does not need to be verified, and in these cases the binary representation suffices. This PR replaces the `aggregate_signature` field in NW's `Certificate` object with its `AsBytes` representation, and the signature is only decompressed when the signature actually have to be verified. According to recently produced perf flame graphs, this could save ~2% CPU usage for validators. ## Test Plan Unit tests. ### Type of Change (Check all that apply) - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [X] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [X] necessitate either a data wipe or data migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Profiling has shown that validators spend a significant amount of CPU resources deserialising the
aggregate_signaturefield in NW'sCertificateobject when read from disk. This is because signatures by default are stored as compressed points, so deserialisation needs to decompress points which is a non-trivial computation. However, in most cases the signature does not need to be verified, and in these cases the binary representation suffices.This PR replaces the
aggregate_signaturefield in NW'sCertificateobject with itsAsBytesrepresentation, and the signature is only decompressed when the signature actually have to be verified. According to recently produced perf flame graphs, this could save ~2% CPU usage for validators.Test Plan
Unit tests.
Type of Change (Check all that apply)