Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upgrades] Accessors for UpgradeCap, UpgradeReceipt, UpgradeTicket #9437

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

amnn
Copy link
Contributor

@amnn amnn commented Mar 16, 2023

Description

Adding Move accessors for the fields on these types, so that upgrade policies can interact with them.

Test Plan

sui/crates/sui-framework-test$ cargo test

Type of Change (Check all that apply)

  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

Adding Move accessors for the fields on these types, so that upgrade policies can interact with them.

Adding Move accessors for the fields on these types, so that upgrade
policies can interact with them.

Test Plan:

```
sui/crates/sui-framework-test$ cargo test
```
@amnn amnn requested review from rvantonder, awelc and tzakian March 16, 2023 23:03
@amnn amnn self-assigned this Mar 16, 2023
@vercel
Copy link

vercel bot commented Mar 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Updated
explorer ⬜️ Ignored (Inspect) Mar 16, 2023 at 11:03PM (UTC)
explorer-storybook ⬜️ Ignored (Inspect) Mar 16, 2023 at 11:03PM (UTC)
wallet-adapter ⬜️ Ignored (Inspect) Mar 16, 2023 at 11:03PM (UTC)

@amnn amnn requested a review from damirka March 16, 2023 23:47
Copy link
Contributor

@damirka damirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the documentation part

@amnn amnn merged commit 7f428e7 into main Mar 17, 2023
@amnn amnn deleted the amnn/upgradecap-accessors branch March 17, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants