wallet-ext: site-connect view show new for every new account #9265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchrysochoidis
requested review from
williamrobertson13,
mystie711,
Jordan-Mysten,
mamos-mysten and
Jibz-Mysten
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
williamrobertson13
approved these changes
Mar 14, 2023
| @@ -40,6 +41,14 @@ export function WalletListSelect({ | |||
| return accounts; | |||
| }, [accounts, visibleValues]); | |||
| const deriveNextAccount = useDeriveNextAccountMutation(); | |||
| useEffect(() => { | |||
There was a problem hiding this comment.
this doesn't feel like it should be an effect since it isn't a side effect of rendering, it's more so a result of someone clicking the "New account" button. I think we could remove this and just update newAccounts from where we call mutate
There was a problem hiding this comment.
yeah good point, I will update it!
* in site-connect view for every newly created account show NEW next to it, instead of only the last one
pchrysochoidis
force-pushed
the
pc-wallet-ext-apps-577-new-for-all
branch
from
0a1fd61 to
7ca580b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-03-14.at.11.57.21.mov
closes APPS-577