Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet-ext: increase popup window size #9245

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

pchrysochoidis
Copy link
Contributor

Description

  • to avoid app scrolling increase the default popup window size (the window used for site-connect, transaction approval etc)
before after
Screenshot 2023-03-14 at 00 34 36 Screenshot 2023-03-14 at 00 32 32
Screenshot 2023-03-14 at 00 35 02 Screenshot 2023-03-14 at 00 32 43
Screenshot 2023-03-14 at 00 34 44 Screenshot 2023-03-14 at 00 33 00

* to avoid app scrolling increase the default popup window size (the window used for site-connect, transaction approval etc)
@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Updated
explorer ⬜️ Ignored (Inspect) Mar 14, 2023 at 0:39AM (UTC)
explorer-storybook ⬜️ Ignored (Inspect) Mar 14, 2023 at 0:39AM (UTC)
wallet-adapter ⬜️ Ignored (Inspect) Mar 14, 2023 at 0:39AM (UTC)

@pchrysochoidis pchrysochoidis merged commit 1b8d3fd into main Mar 14, 2023
@pchrysochoidis pchrysochoidis deleted the pc-wallet-ext-increase-window-size branch March 14, 2023 11:12
@mystie711
Copy link
Collaborator

@pchrysochoidis are we increasing the window size so there is always that extra padding outside the content frame so the pattern background shows up now?

@mystie711
Copy link
Collaborator

Also, the Transaction Summary card seems to have a different color?

@pchrysochoidis
Copy link
Contributor Author

@pchrysochoidis are we increasing the window size so there is always that extra padding outside the content frame so the pattern background shows up now?

The intent was to at least display the content that was hidden. Added the extra padding cause looked a bit better to me. (I can make it smaller so it will hide the bg. Let me know @mystie711 )

@mystie711
Copy link
Collaborator

@pchrysochoidis are we increasing the window size so there is always that extra padding outside the content frame so the pattern background shows up now?

The intent was to at least display the content that was hidden. Added the extra padding cause looked a bit better to me. (I can make it smaller so it will hide the bg. Let me know @mystie711 )

Yes please. Let's update as per our Slack catchup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants