[cli/move] Expose --Xdebug flag for sui move disassemble #8948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replicates a change to the `move` CLI, where the `--Xdebug` flag dumps a compiled module in its most raw form -- the `Debug` format of the `CompiledModule` type in Rust. This helps to see what's going on in the module's pools which are otherwise hidden in the disassembly output. Test Plan: First call to disassemble will forward to the move CLI's `debug` command and print both a source-mapped disassembly, and the raw output, and the second call will print just the raw output: ``` sui$ cargo build sui$ target/debug/sui move disassemble --Xdebug crates/sui-framework/build/Sui/bytecode_modules/pay.mv sui$ cp crates/sui-framework/build/Sui/bytecode_modules/pay.mv /tmp/ sui$ target/debug/sui move disassemble --Xdebug /tmp/pay.mv ```
amnn
added
move
observability
amnn
requested review from
rvantonder,
tnowacki,
tzakian,
sblackshear,
oxade and
dariorussi
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
Nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replicates a change to the
moveCLI, where the--Xdebugflag dumps a compiled module in its most raw form -- theDebugformat of theCompiledModuletype in Rust.This helps to see what's going on in the module's pools which are otherwise hidden in the disassembly output.
Test Plan
First call to disassemble will forward to the move CLI's
debugcommand and print both a source-mapped disassembly, and the raw output, and the second call will print just the raw output: